PATCH for a rather bad cpplib related bug

Dave Brolley brolley@cygnus.com
Sat Jul 31 22:30:00 GMT 1999


Now, that I think about this some more, I recall Per Bothner making a good case for
not putting cpplib specific code into toplev.c. I can't remember the exact reason,
but I recall that it was the whole reason for moving some code out of toplev.c and
into init_parse. Perhaps the best place to check is in fact finish_parse, but
rather than exit there we should simply update the error counter. I've attached a
patch. Comments please.

Zack Weinberg wrote:

> On Mon, 05 Jul 1999 11:45:20 -0400, Dave Brolley wrote:
> >I don't think finish_parse is a good place for this check. There is alot that
> >gets done after finish_parse is called from compile_file in toplev.c. Also, ea
> >ch
> >language has it's own finish_parse, so you would need to fix each language tha
> >t uses cpplib (C, C++, OBJC). Perhaps this should be checked at the end of 'ma
> >in'
> >along with the other checks of this nature.
>
> Yeah, I was wondering about that too.  Perhaps something like this would
> be more appropriate?  (All the front ends that use cpplib call the reader
> structure parse_in.)




More information about the Gcc-patches mailing list