[PATCH] Java: temporary fix to cope with recent tree.h changes.

Jeffrey A Law law@cygnus.com
Fri Dec 31 16:38:00 GMT 1999


  In message < 199912110056.QAA08658@deliverance.cygnus.com >you write:
  > The recent changes to tree.h are breaking the Java front-end,
  > something that I'll work on fixing ASAP -- this is independent from
  > the work that needs to be done in order for the Java front-end to do
  > The Right Thing as far as handling qualified expressions (using
  > COMPONENT_REF.)
  > 
  > Historically, with TREE_CHAIN used to hold the filename of a
  > EXPR_WITH_FILE_LOCATION (WFL), it left operand1 free for front-end
  > specific use, which is what the Java front-end took advantage of. The
  > issue over the use of TREE_CHAIN for something else than chaining
  > nodes was moderately debated when WFLs were introduced
  > ( http://www.cygnus.com/ml/egcs/1998-Mar/0831.html ).
  > 
  > Mark Mitchell's patch to tree.h
  > ( http://gcc.gnu.org/ml/gcc-patches/1999-12/msg00133.html ) stores the
  > filename in operand1 and TREE_CHAIN can be now used to link WFLs
  > together. Of course, this conflict with the use the Java front-end
  > makes of operand1.
  > 
  > This patch is a temporary fix in order for the Java front-end to keep
  > on working. It extends the number of operand a WFL can have to 3 and
  > instruct the Java parser to now use operand2 instead of operand1.
  > 
  > I need approval to check in the non Java part of this patch.
  > 
  > ./A
  > 
  > Fri Dec 10 16:12:13 1999  Alexandre Petit-Bianco  <apbianco@cygnus.com>
  > 
  > 	* tree.def (EXPR_WITH_FILE_LOCATION): To temporary feature three
  >  	operands, until the Java front-end gets fixed with regard to Mark
  >  	Mitchell's tree.h patch (1999-12-04.)
I'm a little confused.  Initially your explanation states that this is needed
to DTRT for handling qualified expressions.  But later you state that it's
a temporary fix.  If it's just a temporary fix, how long until the real fix
is available -- depending on the timeframe , it may not make sense to put in
a band-aid like this.

Which is it?  A short term fix, or a necessary step to DTRT.

jeff





More information about the Gcc-patches mailing list