Patch: make __eprintf take ellipses and delete it from cp/tree.c
Kaveh R. Ghazi
ghazi@caip.rutgers.edu
Mon Dec 27 08:48:00 GMT 1999
> From: Richard Henderson <rth@cygnus.com>
>
> On Sun, Dec 26, 1999 at 09:32:14AM -0500, Kaveh R. Ghazi wrote:
> > 1. Change __eprintf to use ellipses instead of fixed args.
>
> Why? It's always called with fixed args. All this change does
> is make most risc machines spill potential argument registers to
> the stack.
It eliminated a warning about a non-literal format string. That's not
very important, and I didn't realize it would slow things down.
However even knowing that, it is worthwhile to realize that __eprintf
is only executed just prior to calling abort() as part of the assert()
macro expansion. So it won't slow down running code by any amount
unless you are crashing a whole lot and need to examine the problem a
nanosecond sooner. :-)
In this light, do we care about the slow down?
--
Kaveh R. Ghazi Engagement Manager / Project Services
ghazi@caip.rutgers.edu Qwest Internet Solutions
More information about the Gcc-patches
mailing list