Don't override USER_H on FreeBSD

Jeffrey A Law law@cygnus.com
Wed Aug 25 00:04:00 GMT 1999


  In message < 199908022309.SAA77004@latour.rsch.comm.mot.com >you write:
  > [This is a resend due to possible ORBS rejection.]
  > 
  > Mon Aug  2 16:43:34 CDT 1999 Loren Rittle  <ljrittle@acm.org>
  > 
  >        * config/t-freebsd: Do not override USER_H.
  >        * ginclude/stdarg.h (__gnuc_va_list): Adhere to definition of
  > 			   va_list in FreeBSD system headers.
  >        * ginclude/stddef.h (_BSD_PTRDIFF_T_): Do not redefine after use.
  >        (_BSD_SIZE_T_, _BSD_WCHAR_T_): Likewise.
I do not think this patch is anywhere near complete.  Particularly the
stddef.h changes.

I think you need to look at every hunk of code in stddef.h which uses or
defines BSD_SIZE_T, BSD_WCHAR_T & BSD_PTRDIFF_T and do the right thing.  In
some cases that may mean deleting the references, or it may mean changing
them.

If they are correct, I need the analysis which shows they are correct.  If they
are obsolete, I need that analysis and a patch to remove all the obsolete uses,
not just some of them.

In general, given the uglyness of stddef.h a patch to it needs to be well
understood.

I believe you also need update varargs.h in a manner similar to stdarg.h.

I believe the t-freebsd change it OK, but I'm not going to install it since
doing so without the associated stdarg.h, varargs.h and stddef.h changes will
cause more problems than it solves.

just going to 

jeff





More information about the Gcc-patches mailing list