RTL consistency questions

Zack Weinberg zack@rabi.columbia.edu
Wed Apr 14 05:54:00 GMT 1999


On Wed, 14 Apr 1999 00:51:10 -0600, Jeffrey A Law wrote:
>
>  In message < 199904130328.XAA22804@blastula.phys.columbia.edu >you write:
>  > >One file at a time if it's not _too_ many changes ought to be reasonable.
>  > 
>  > Try this on for size.  It's just the changes that fix real bugs.
>  > Touches three files.
[...]
>  > @@ -3095,6 +3097,8 @@
>  >  
>  >      case 'b':
>  >      case '3':
>  > +      if (op0_mode != VOIDmode)
>  > +	abort ();
>  >        new = simplify_ternary_operation (code, GET_MODE (x), op0_mode,
>  >  					XEXP (x, 0), XEXP (x, 1), XEXP (x, 2));
>  >        break;
>I'm not sure this last hunk is correct.  Doesn't 'b' match a ZERO_EXTRACT
>and/or SIGN_EXTRACT code?  Those codes should have a non-VOID mode.

Oops.  That was supposed to be if (op0_mode == MAX_MACHINE_MODE) just
like the other hunk.

Is this part OK with that change?

zw


More information about the Gcc-patches mailing list