(libio) _POSIX_SOURCE cleanup patch

Mumit Khan khan@xraylith.wisc.EDU
Mon Apr 12 08:22:00 GMT 1999


Jeffrey A Law <law@upchuck.cygnus.com> writes:
> 
>   In message < Pine.SUN.3.93.990411184331.17312F-100000@modi.xraylith.wisc.edu
> >y
> ou write:
>   > 
>   > This patch removes the various _POSIX_SOURCE definitions from various
>   > files in libio and puts it in libioP.h.
>   > 
>   > diff against 19990410 CVS. Needed to bootstrap on i386-pc-interix
>   > which requires the use of _POSIX_SOURCE to expose fileno. Bootstrap 
>   > sanity checked on i686-pc-linux-gnu and hppa1.1-hp-hpux10.20.
>   > 
>   > Sun Apr 11 13:32:54 1999  Mumit Khan  <khan@xraylith.wisc.edu>
>   > 
>   > 	* filedoalloc.c (_POSIX_SOURCE): Remove definition.
>   > 	* fileops.c (_POSIX_SOURCE): Likewise.
>   > 	* iopopen.c (_POSIX_SOURCE): Likewise.
>   > 	* procbuf.cc (_POSIX_SOURCE): Likewise.
>   > 	* libioP.h (_POSIX_SOURCE): And define it here.
>   > 	* stdiostream.cc: Include libioP.h before others.
> Is this what you and Ulrich decided was the final solution?  I can find some
> of the early discussion in the archives, but no final resolution.
> 

Both you and Ulrich had (justifiably) objected to my extending the 
current method of defining _POSIX_SOURCE in the files directly, and 
suggested that either (1) it goes in a common header, or (2) via 
Makefile. Given the way the libio configuration works, this approach 
makes more sense to me.

Regards,
Mumit



More information about the Gcc-patches mailing list