warning patches part 1/2

Kaveh R. Ghazi ghazi@caip.rutgers.edu
Tue Oct 13 14:27:00 GMT 1998


 > From: Jeffrey A Law <law@cygnus.com>
 > 
 >   In message < 199810121601.MAA19030@caip.rutgers.edu >you write:
 >   > 
 >   > Mon Oct 12 10:29:55 1998  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
 >   > 	* c-decl.c (c_decode_option): Ifndef USE_CPPLIB, mark parameter
 >   >  `argc' with ATTRIBUTE_UNUSED.
 > 
 > This is rather silly and doesn't help readability in any way.

	I agree, but last time I used ATTRIBUTE_UNUSED unconditionally,
one of the other egcs maintainers complained.  (I forgot who.)  I'll do
as you ask. 


 >   Can we
 > just mark it as unused unconditionally instead of farting around ...

	*My* farts don't smell. :-)


 > with
 > trying to determine exactly under what set of macro defitions these
 > things may be unused?
 > I don't think conditionalizing that is worth the pain.
 > Similarly for other cases where you've conditionally used ATTRIBUTE_UNUSED.
 > The rest of the changes look OK to me.
 > jeff

	Okay I'll install parts 1&2 with with the change you've requested.

		--Kaveh
--
Kaveh R. Ghazi			Engagement Manager / Project Services
ghazi@caip.rutgers.edu		Icon CMT Corp.



More information about the Gcc-patches mailing list