FIX_REGISTER_CHECK

Jim Wilson wilson@cygnus.com
Wed Oct 7 20:00:00 GMT 1998


The patch seems incomplete, in two different ways.
1) You are adding an error message for invalid -fcall* options, but you
   only do so for two registers.  You don't give errors for all invalid
   options.
2) You are adding an error message for invalid -fcall* options, but you
   only do so for one target.  You don't give errors for all targets.
Both of these problems seem undesirable to me.

If it is really only the stack pointer and frame pointer that you are worried
about at this time, then why make the patch MIPS specific?  These registers
would be invalid for all targets.  It would make the patch simpler to check
them for every target.  This would avoid the need for a new machine dependent
macro, and eliminates one of my objections, and gives a good argument against
the other.

Jim



More information about the Gcc-patches mailing list