PATCH: correct handling of `.zip' files

Tom Tromey tromey@cygnus.com
Wed Nov 25 23:12:00 GMT 1998


Alexandre> How about the attached patch?  Ok to install?

It is ok except for one little nit.

Alexandre> -  if (len > 4 && ! strcmp (filename + len - 4, ".zip"))
Alexandre> +  if (len > 4 && (! strcmp (filename + len - 4, ".zip") ||
Alexandre> +		  ! strcmp (filename + len - 4, ".jar")))

In the GNU coding standards the `||' must appear on the second line:

 if (len > 4 && (! strcmp (filename + len - 4, ".zip")
                 || ! strcmp (filename + len - 4, ".jar")))

Feel free to check it in once this change is made.

Tom



More information about the Gcc-patches mailing list