safe_from_p changes tree code

Mark Mitchell mark@markmitchell.com
Sun Jun 28 22:51:00 GMT 1998


>>>>> "Martin" == Martin von Loewis <martin@mira.isdn.cs.tu-berlin.de> writes:

    Martin> A recent change in safe_from_p broke --enable-checking; an
    Martin> error mark is now accessed as an expression. This patch
    Martin> introduces a new access macro.

I would rather set/unset the tree code to ERROR_MARK around each
recursive call than introduce this new accessor.  The new accessor
only encourages its usage, which is ugly.  The kind of thing that
safe_from_p is doing is, IMO, rather unattractive.  It's not that
there wasn't a good reason for the Craig's patch, but I feel strongly
that one should only look at _OPERANDs of things that are
expressions. 

-- 
Mark Mitchell 			mark@markmitchell.com
Mark Mitchell Consulting	http://www.markmitchell.com



More information about the Gcc-patches mailing list