[gcc r17-165] phiprop: Fix typo [PR125067]

Andrew Pinski pinskia@gcc.gnu.org
Tue Apr 28 21:27:57 GMT 2026


https://gcc.gnu.org/g:67812af709d121b73d582093aa9aeccf149b07ba

commit r17-165-g67812af709d121b73d582093aa9aeccf149b07ba
Author: Andrew Pinski <andrew.pinski@oss.qualcomm.com>
Date:   Tue Apr 28 12:46:31 2026 -0700

    phiprop: Fix typo [PR125067]
    
    When I factored out the code in can_handle_load, I had a small typo
    which seemed to work for most cases but I had noticed later on was
    broken. Basically the bb where the vop definition has to be dominated
    by the current bb (and can't be the current bb).
    
    Pushed as obvious afte a quick bootstrapped.
    
            PR tree-optimization/125067
    
    gcc/ChangeLog:
    
            * tree-ssa-phiprop.cc (can_handle_load): Fix copy and pasto
            on dominated_by_p.
    
    Signed-off-by: Andrew Pinski <andrew.pinski@oss.qualcomm.com>

Diff:
---
 gcc/tree-ssa-phiprop.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/tree-ssa-phiprop.cc b/gcc/tree-ssa-phiprop.cc
index 07c81fdce28f..b7ce7b4a1845 100644
--- a/gcc/tree-ssa-phiprop.cc
+++ b/gcc/tree-ssa-phiprop.cc
@@ -259,8 +259,8 @@ can_handle_load (gimple *load_stmt, basic_block bb,
   if (SSA_NAME_IS_DEFAULT_DEF (vuse))
     return true;
   if (gimple_bb (def_stmt) != bb
-      && !dominated_by_p (CDI_DOMINATORS,
-			  bb, gimple_bb (def_stmt)))
+      && dominated_by_p (CDI_DOMINATORS,
+			 bb, gimple_bb (def_stmt)))
     return true;
   return false;
 }


More information about the Gcc-cvs mailing list