[gcc r16-3522] s390: Adjust s390/spaceship-fp-*.c tests for recent changes
Jakub Jelinek
jakub@gcc.gnu.org
Tue Sep 2 15:02:58 GMT 2025
https://gcc.gnu.org/g:a41d8edf304e896cb541a0ec7daafb02b8d442c7
commit r16-3522-ga41d8edf304e896cb541a0ec7daafb02b8d442c7
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Sep 2 17:01:30 2025 +0200
s390: Adjust s390/spaceship-fp-*.c tests for recent changes
In r16-3414 libstdc++ changed ABI for (still experimental C++20) and uses
unordered value -128 instead of 2. Generally the change improved code
generation on all targets tested, see
https://gcc.gnu.org/pipermail/gcc-patches/2025-August/693534.html
for details.
In r16-3474 I've adjusted the middle-end and backends to use that value.
This apparently broke the gcc.target/s390/spaceship-fp-2.c test,
with -ffast-math the 2 value is unreachable and so the .SPACESHIP last
argument in that case is the default, which changed from 2 to -128.
But spaceship-fp-1.c test also doesn't test what libstdc++ uses anymore,
so the following patch uses -128 in all the spots.
2025-09-02 Jakub Jelinek <jakub@redhat.com>
* gcc.target/s390/spaceship-fp-1.c: Expect .SPACESHIP call with
-128 as last argument instead of 2.
(TEST): Use -128 instead of 2.
* gcc.target/s390/spaceship-fp-2.c: Expect .SPACESHIP call with
-128 as last argument instead of 2.
(TEST): Use -128 instead of 2.
Diff:
---
gcc/testsuite/gcc.target/s390/spaceship-fp-1.c | 4 ++--
gcc/testsuite/gcc.target/s390/spaceship-fp-2.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gcc/testsuite/gcc.target/s390/spaceship-fp-1.c b/gcc/testsuite/gcc.target/s390/spaceship-fp-1.c
index 56c3d77de3ce..34b9ba66d7b0 100644
--- a/gcc/testsuite/gcc.target/s390/spaceship-fp-1.c
+++ b/gcc/testsuite/gcc.target/s390/spaceship-fp-1.c
@@ -1,6 +1,6 @@
/* { dg-do compile { target lp64 } } */
/* { dg-options "-O2 -mzarch -march=z13 -fdump-tree-optimized" } */
-/* { dg-final { scan-tree-dump-times {\.SPACESHIP \([^,]+, [^,]+, 2\)} 3 optimized } } */
+/* { dg-final { scan-tree-dump-times {\.SPACESHIP \([^,]+, [^,]+, -128\)} 3 optimized } } */
/* { dg-final { scan-assembler-times {\tk[edx]br\t} 3 } } */
/* { dg-final { scan-assembler-not {\tbrc} } } */
/* { dg-final { scan-assembler-not {\tc[edx]br\t} } } */
@@ -15,7 +15,7 @@
else if (x > y) \
return 1; \
else \
- return 2; \
+ return -128; \
}
TEST (float, float)
diff --git a/gcc/testsuite/gcc.target/s390/spaceship-fp-2.c b/gcc/testsuite/gcc.target/s390/spaceship-fp-2.c
index 0c6e6b6aeb4f..6fe4d22b2783 100644
--- a/gcc/testsuite/gcc.target/s390/spaceship-fp-2.c
+++ b/gcc/testsuite/gcc.target/s390/spaceship-fp-2.c
@@ -1,6 +1,6 @@
/* { dg-do compile { target lp64 } } */
/* { dg-options "-O2 -mzarch -march=z13 -ffinite-math-only -fdump-tree-optimized" } */
-/* { dg-final { scan-tree-dump-times {\.SPACESHIP \([^,]+, [^,]+, 2\)} 3 optimized } } */
+/* { dg-final { scan-tree-dump-times {\.SPACESHIP \([^,]+, [^,]+, -128\)} 3 optimized } } */
/* { dg-final { scan-assembler-times {\tc[edx]br\t} 3 } } */
/* { dg-final { scan-assembler-not {\tbrc} } } */
/* { dg-final { scan-assembler-not {\tk[edx]br\t} } } */
@@ -15,7 +15,7 @@
else if (x > y) \
return 1; \
else \
- return 2; \
+ return -128; \
}
TEST (float, float)
More information about the Gcc-cvs
mailing list