[gcc r16-3493] testsuite: arm: factorize arm_v8_neon_ok flags

Christophe Lyon clyon@gcc.gnu.org
Mon Sep 1 14:57:58 GMT 2025


https://gcc.gnu.org/g:32d3f5744a1f263c9b1a3f0aae2127940bddb775

commit r16-3493-g32d3f5744a1f263c9b1a3f0aae2127940bddb775
Author: Christophe Lyon <christophe.lyon@linaro.org>
Date:   Sun Apr 27 20:34:33 2025 +0000

    testsuite: arm: factorize arm_v8_neon_ok flags
    
    Like we do in other effective-targets, add
    "-mcpu=unset -march=armv8-a"
    directly when setting et_arm_v8_neon_flags in arm_v8_neon_ok_nocache,
    to avoid having to add these two flags in all users of arm_v8_neon_ok.
    
    This avoids duplication and possible typos / oversights.
    
    gcc/testsuite/ChangeLog:
            * lib/target-supports.exp
            (check_effective_target_arm_v8_neon_ok_nocache): Add "-mcpu=unset
            -march=armv8-a" to et_arm_v8_neon_flags.
            (add_options_for_vect_early_break): Remove useless "-mcpu=unset
            -march=armv8-a".
            (add_options_for_arm_v8_neon): Likewise.

Diff:
---
 gcc/testsuite/lib/target-supports.exp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp
index b09675d24891..957fa7f3599e 100644
--- a/gcc/testsuite/lib/target-supports.exp
+++ b/gcc/testsuite/lib/target-supports.exp
@@ -4639,7 +4639,7 @@ proc add_options_for_vect_early_break { flags } {
 
     if { [check_effective_target_arm_v8_neon_ok] } {
 	global et_arm_v8_neon_flags
-	return "$flags $et_arm_v8_neon_flags -mcpu=unset -march=armv8-a"
+	return "$flags $et_arm_v8_neon_flags"
     }
 
     if { [check_effective_target_sse4] } {
@@ -5462,7 +5462,7 @@ proc add_options_for_arm_v8_neon { flags } {
 	return "$flags"
     }
     global et_arm_v8_neon_flags
-    return "$flags $et_arm_v8_neon_flags -mcpu=unset -march=armv8-a"
+    return "$flags $et_arm_v8_neon_flags"
 }
 
 # Add the options needed for ARMv8.1 Adv.SIMD.  Also adds the ARMv8 NEON
@@ -5931,7 +5931,7 @@ proc check_effective_target_arm_v8_neon_ok_nocache { } {
 		__asm__ volatile ("vrintn.f32 q0, q0");
 	    }
 	} "$flags -mcpu=unset -march=armv8-a"] } {
-	    set et_arm_v8_neon_flags $flags
+	    set et_arm_v8_neon_flags "$flags -mcpu=unset -march=armv8-a"
 	    return 1
 	}
     }


More information about the Gcc-cvs mailing list