[gcc r15-8427] gccrs: Insert static items into the value namespace
Arthur Cohen
cohenarthur@gcc.gnu.org
Wed Mar 19 14:44:12 GMT 2025
https://gcc.gnu.org/g:0d88e726aa017db639fa8848d7ec5be2ecc13507
commit r15-8427-g0d88e726aa017db639fa8848d7ec5be2ecc13507
Author: Owen Avery <powerboat9.gamer@gmail.com>
Date: Fri Oct 11 01:24:14 2024 -0400
gccrs: Insert static items into the value namespace
gcc/rust/ChangeLog:
* backend/rust-compile-item.cc
(CompileItem::visit): Check canonical path of StaticItem
properly when name resolution 2.0 is enabled.
* resolve/rust-toplevel-name-resolver-2.0.cc
(TopLevel::visit): Insert static items into the value namespace.
gcc/testsuite/ChangeLog:
* rust/compile/nr2/exclude: Remove entries.
Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
Diff:
---
gcc/rust/backend/rust-compile-item.cc | 19 +++++++++++++++++--
gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc | 3 +++
gcc/testsuite/rust/compile/nr2/exclude | 2 --
3 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/gcc/rust/backend/rust-compile-item.cc b/gcc/rust/backend/rust-compile-item.cc
index c0cac686e8d9..08787163c2a5 100644
--- a/gcc/rust/backend/rust-compile-item.cc
+++ b/gcc/rust/backend/rust-compile-item.cc
@@ -42,8 +42,23 @@ CompileItem::visit (HIR::StaticItem &var)
tree type = TyTyResolveCompile::compile (ctx, resolved_type);
- auto canonical_path = ctx->get_mappings ().lookup_canonical_path (
- var.get_mappings ().get_nodeid ());
+ tl::optional<Resolver::CanonicalPath> canonical_path;
+
+ if (flag_name_resolution_2_0)
+ {
+ auto nr_ctx
+ = Resolver2_0::ImmutableNameResolutionContext::get ().resolver ();
+
+ canonical_path
+ = nr_ctx.values.to_canonical_path (var.get_mappings ().get_nodeid ());
+ }
+ else
+ {
+ canonical_path = ctx->get_mappings ().lookup_canonical_path (
+ var.get_mappings ().get_nodeid ());
+ }
+
+ rust_assert (canonical_path.has_value ());
HIR::Expr *const_value_expr = var.get_expr ().get ();
ctx->push_const_context ();
diff --git a/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc b/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc
index b0e0c1b52dce..d3a3c5d78bc9 100644
--- a/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc
+++ b/gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc
@@ -248,6 +248,9 @@ TopLevel::visit (AST::StaticItem &static_item)
= [this, &static_item] () { static_item.get_expr ().accept_vis (*this); };
ctx.scoped (Rib::Kind::Item, static_item.get_node_id (), sub_vis);
+
+ insert_or_error_out (static_item.get_identifier ().as_string (), static_item,
+ Namespace::Values);
}
void
diff --git a/gcc/testsuite/rust/compile/nr2/exclude b/gcc/testsuite/rust/compile/nr2/exclude
index 1faa7b53622e..166977e7bacc 100644
--- a/gcc/testsuite/rust/compile/nr2/exclude
+++ b/gcc/testsuite/rust/compile/nr2/exclude
@@ -100,8 +100,6 @@ issue-2139.rs
issue-2142.rs
issue-2165.rs
issue-2166.rs
-issue-2178.rs
-issue-2188.rs
issue-2190-1.rs
issue-2190-2.rs
issue-2195.rs
More information about the Gcc-cvs
mailing list