[gcc r15-3748] analyzer: remove redundant 'pp' [PR116613]

[David Malcolm]

https://gcc.gnu.org/g:37604edf37b3799e0203ede4dfa60d547322fdfc

commit r15-3748-g37604edf37b3799e0203ede4dfa60d547322fdfc
Author: David Malcolm <dmalcolm@redhat.com>
Date:   Fri Sep 20 18:51:55 2024 -0400

    analyzer: remove redundant 'pp' [PR116613]
    
    diagnostic_manager::emit_saved_diagnostic makes a useless clone
    of global_dc->m_printer; remove it.
    
    No functional change intended.
    
    gcc/analyzer/ChangeLog:
            PR other/116613
            * diagnostic-manager.cc (diagnostic_manager::emit_saved_diagnostic):
            Remove remove redundant 'pp'.
    
    Signed-off-by: David Malcolm <dmalcolm@redhat.com>

Diff:
---
 gcc/analyzer/diagnostic-manager.cc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/gcc/analyzer/diagnostic-manager.cc b/gcc/analyzer/diagnostic-manager.cc
index 4a5a95136156..2363ae5df19c 100644
--- a/gcc/analyzer/diagnostic-manager.cc
+++ b/gcc/analyzer/diagnostic-manager.cc
@@ -1561,8 +1561,6 @@ diagnostic_manager::emit_saved_diagnostic (const exploded_graph &eg,
        sd.get_index (), sd.m_d->get_kind (), sd.m_snode->m_index);
   log ("num dupes: %i", sd.get_num_dupes ());
 
-  pretty_printer *pp = global_dc->m_printer->clone ();
-
   const exploded_path *epath = sd.get_best_epath ();
   gcc_assert (epath);
 
@@ -1645,7 +1643,6 @@ diagnostic_manager::emit_saved_diagnostic (const exploded_graph &eg,
 	  free (filename);
 	}
     }
-  delete pp;
 }
 
 /* Emit a "path" of events to EMISSION_PATH describing the exploded path