[gcc r15-4076] cfgexpand: Expand comment on when non-var clobbers can show up

Andrew Pinski pinskia@gcc.gnu.org
Fri Oct 4 15:33:33 GMT 2024


https://gcc.gnu.org/g:6064420ebddede802904a740363047b5403598d1

commit r15-4076-g6064420ebddede802904a740363047b5403598d1
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Thu Oct 3 02:23:55 2024 +0000

    cfgexpand: Expand comment on when non-var clobbers can show up
    
    The comment here is not wrong, just it would be better if mentioning
    the C++ front-end instead of just the nested function lowering.
    
    gcc/ChangeLog:
    
            * cfgexpand.cc (add_scope_conflicts_1): Expand comment
            on when non-var clobbers show up.
    
    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

Diff:
---
 gcc/cfgexpand.cc | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gcc/cfgexpand.cc b/gcc/cfgexpand.cc
index f32cf1b20c9a..6c1096363afb 100644
--- a/gcc/cfgexpand.cc
+++ b/gcc/cfgexpand.cc
@@ -639,8 +639,9 @@ add_scope_conflicts_1 (basic_block bb, bitmap work, bool for_conflict)
 	{
 	  tree lhs = gimple_assign_lhs (stmt);
 	  unsigned *v;
-	  /* Nested function lowering might introduce LHSs
-	     that are COMPONENT_REFs.  */
+	  /* Handle only plain var clobbers.
+	     Nested functions lowering and C++ front-end inserts clobbers
+	     which are not just plain variables.  */
 	  if (!VAR_P (lhs))
 	    continue;
 	  if (DECL_RTL_IF_SET (lhs) == pc_rtx


More information about the Gcc-cvs mailing list