[gcc r14-8322] [committed] [NFC] Fix riscv_init_cumulative_args for unused arguments

Jeff Law law@gcc.gnu.org
Sun Jan 21 22:44:41 GMT 2024


https://gcc.gnu.org/g:b1829de17bdf9770b276756ead49eba6f408ecd1

commit r14-8322-gb1829de17bdf9770b276756ead49eba6f408ecd1
Author: Jeff Law <jlaw@ventanamicro.com>
Date:   Sun Jan 21 15:41:38 2024 -0700

    [committed] [NFC] Fix riscv_init_cumulative_args for unused arguments
    
    The signature was still using ATTRIBUTE_UNUSED and actually marked one
    of the used arguments with ATTRIBUTE_UNUSED.
    
    This patch drops the decorations and instead remove the name of arguments
    which are actually unused which is the preferred way to handle this now
    when we can.
    
    Bootstrapped.  I didn't have test results on the platform where I
    bootstrapped, so no results to compare against.  Given its NFC, I
    think we're OK without the regression results.
    
    gcc/
            * config/riscv/riscv.cc (riscv_init_cumulative_args): Update and
            fix bugs in signature.

Diff:
---
 gcc/config/riscv/riscv.cc | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 1f9546f4d3e..5ee54b92033 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -4872,12 +4872,7 @@ riscv_pass_fpr_pair (machine_mode mode, unsigned regno1,
    for a call to a function whose data type is FNTYPE.
    For a library call, FNTYPE is 0.  */
 
-void
-riscv_init_cumulative_args (CUMULATIVE_ARGS *cum,
-			    tree fntype ATTRIBUTE_UNUSED,
-			    rtx libname ATTRIBUTE_UNUSED,
-			    tree fndecl ATTRIBUTE_UNUSED,
-			    int caller ATTRIBUTE_UNUSED)
+riscv_init_cumulative_args (CUMULATIVE_ARGS *cum, tree fntype, rtx, tree, int)
 {
   memset (cum, 0, sizeof (*cum));


More information about the Gcc-cvs mailing list