[gcc r14-8075] gccrs: Fix warning with overridden virtual methods

Arthur Cohen cohenarthur@gcc.gnu.org
Tue Jan 16 18:16:30 GMT 2024


https://gcc.gnu.org/g:b37170179b5e32e76758c0678182461e834aca44

commit r14-8075-gb37170179b5e32e76758c0678182461e834aca44
Author: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Date:   Mon Oct 23 16:09:54 2023 +0200

    gccrs: Fix warning with overridden virtual methods
    
    Overridden virtual methods were not marked as such.
    
    gcc/rust/ChangeLog:
    
            * ast/rust-pattern.h: Add override modifier to overriding methods.
    
    Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Diff:
---
 gcc/rust/ast/rust-pattern.h | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/gcc/rust/ast/rust-pattern.h b/gcc/rust/ast/rust-pattern.h
index 6ee1417a1fd..6a90b536175 100644
--- a/gcc/rust/ast/rust-pattern.h
+++ b/gcc/rust/ast/rust-pattern.h
@@ -49,7 +49,7 @@ public:
 
   void accept_vis (ASTVisitor &vis) override;
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
   Literal &get_literal () { return lit; }
 
@@ -147,7 +147,7 @@ public:
   bool get_is_mut () const { return is_mut; }
   bool get_is_ref () const { return is_ref; }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -175,7 +175,7 @@ public:
 
   void accept_vis (ASTVisitor &vis) override;
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -429,7 +429,7 @@ public:
     return upper;
   }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -497,7 +497,7 @@ public:
 
   bool get_is_mut () const { return is_mut; }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -932,7 +932,7 @@ public:
   PathInExpression &get_path () { return path; }
   const PathInExpression &get_path () const { return path; }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -1169,7 +1169,7 @@ public:
   PathInExpression &get_path () { return path; }
   const PathInExpression &get_path () const { return path; }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -1409,7 +1409,7 @@ public:
     return items;
   }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -1469,7 +1469,7 @@ public:
     return pattern_in_parens;
   }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -1533,7 +1533,7 @@ public:
     return items;
   }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather
@@ -1598,7 +1598,7 @@ public:
     return alts;
   }
 
-  NodeId get_node_id () const { return node_id; }
+  NodeId get_node_id () const override { return node_id; }
 
 protected:
   /* Use covariance to implement clone function as returning this object rather


More information about the Gcc-cvs mailing list