[gcc r14-7524] gccrs: Fix ICE when we dont get a reference type

Arthur Cohen cohenarthur@gcc.gnu.org
Tue Jan 16 17:41:22 GMT 2024


https://gcc.gnu.org/g:73ed16c0f8bc157bcb905e87cffcfd616ee7ea04

commit r14-7524-g73ed16c0f8bc157bcb905e87cffcfd616ee7ea04
Author: Philip Herron <herron.philip@googlemail.com>
Date:   Fri Apr 21 17:52:01 2023 +0100

    gccrs: Fix ICE when we dont get a reference type
    
    gcc/rust/ChangeLog:
    
            * typecheck/rust-hir-type-check-pattern.cc (TypeCheckPattern::visit):
            return so we dont hit undefined behaviour
    
    Signed-off-by: Philip Herron <herron.philip@googlemail.com>

Diff:
---
 gcc/rust/typecheck/rust-hir-type-check-pattern.cc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/gcc/rust/typecheck/rust-hir-type-check-pattern.cc b/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
index f793b61cd99..bde70768238 100644
--- a/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
+++ b/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
@@ -362,8 +362,11 @@ void
 TypeCheckPattern::visit (HIR::ReferencePattern &pattern)
 {
   if (parent->get_kind () != TyTy::TypeKind::REF)
-    rust_error_at (pattern.get_locus (), "expected %s, found reference",
-		   parent->as_string ().c_str ());
+    {
+      rust_error_at (pattern.get_locus (), "expected %s, found reference",
+		     parent->as_string ().c_str ());
+      return;
+    }
 
   TyTy::ReferenceType *ref_ty_ty = static_cast<TyTy::ReferenceType *> (parent);
   TyTy::BaseType *infered_base


More information about the Gcc-cvs mailing list