[gcc r14-7338] gccrs: Resolve closure parameters without given type

Arthur Cohen cohenarthur@gcc.gnu.org
Tue Jan 16 17:23:32 GMT 2024


https://gcc.gnu.org/g:234e7176a5d337af632b67380163d7bbd3526f3a

commit r14-7338-g234e7176a5d337af632b67380163d7bbd3526f3a
Author: Owen Avery <powerboat9.gamer@gmail.com>
Date:   Fri Mar 3 20:05:59 2023 -0500

    gccrs: Resolve closure parameters without given type
    
    gcc/rust/ChangeLog:
    
            * resolve/rust-early-name-resolver.cc
            (EarlyNameResolver::visit):
            Check for closure parameter without given type.
    
    gcc/testsuite/ChangeLog:
    
            * rust/compile/closure_no_type_anno.rs: Extend test.
    
    Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>

Diff:
---
 gcc/rust/resolve/rust-early-name-resolver.cc       | 3 ++-
 gcc/testsuite/rust/compile/closure_no_type_anno.rs | 9 +++++++--
 2 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/gcc/rust/resolve/rust-early-name-resolver.cc b/gcc/rust/resolve/rust-early-name-resolver.cc
index 6dc11c41bc4..c6cbdb0a21b 100644
--- a/gcc/rust/resolve/rust-early-name-resolver.cc
+++ b/gcc/rust/resolve/rust-early-name-resolver.cc
@@ -326,7 +326,8 @@ EarlyNameResolver::visit (AST::ClosureExprInner &expr)
   expr.get_definition_expr ()->accept_vis (*this);
 
   for (auto &param : expr.get_params ())
-    param.get_type ()->accept_vis (*this);
+    if (param.has_type_given ())
+      param.get_type ()->accept_vis (*this);
 }
 
 void
diff --git a/gcc/testsuite/rust/compile/closure_no_type_anno.rs b/gcc/testsuite/rust/compile/closure_no_type_anno.rs
index beade7607f0..ff2c8b88a8a 100644
--- a/gcc/testsuite/rust/compile/closure_no_type_anno.rs
+++ b/gcc/testsuite/rust/compile/closure_no_type_anno.rs
@@ -1,5 +1,10 @@
-// { dg-additional-options "-fsyntax-only" }
+#[lang = "fn_once"]
+trait FnOnce<Args> {
+  type Output;
+
+  fn call_once(self, args: Args) -> Self::Output;
+}
 
 pub fn foo() {
-  let a = |_| 15;
+  let a = |_| 15; // { dg-error "type annotations needed" }
 }


More information about the Gcc-cvs mailing list