[gcc r14-7337] gccrs: make predicate bounds overwrite-able
Arthur Cohen
cohenarthur@gcc.gnu.org
Tue Jan 16 17:23:26 GMT 2024
https://gcc.gnu.org/g:1e1bcabf1c6aabb5b5eb5abf6689b88313dbb736
commit r14-7337-g1e1bcabf1c6aabb5b5eb5abf6689b88313dbb736
Author: Philip Herron <herron.philip@googlemail.com>
Date: Fri Mar 3 18:17:50 2023 +0000
gccrs: make predicate bounds overwrite-able
When compiling types especially when using queries it needs to be
permissive and allow them to be overwritten and a predicate might have one
set of details in one senario and a new one with the same id later on but
with different types.
Fixes #1524
Signed-off-by: Philip Herron <herron.philip@googlemail.com>
gcc/rust/ChangeLog:
* typecheck/rust-typecheck-context.cc (TypeCheckContext::insert_resolved_predicate): remove
gcc/testsuite/ChangeLog:
* rust/compile/issue-1524.rs: New test.
Diff:
---
gcc/rust/typecheck/rust-typecheck-context.cc | 4 +--
gcc/testsuite/rust/compile/issue-1524.rs | 49 ++++++++++++++++++++++++++++
2 files changed, 51 insertions(+), 2 deletions(-)
diff --git a/gcc/rust/typecheck/rust-typecheck-context.cc b/gcc/rust/typecheck/rust-typecheck-context.cc
index 04135e7115d..093bc0a702e 100644
--- a/gcc/rust/typecheck/rust-typecheck-context.cc
+++ b/gcc/rust/typecheck/rust-typecheck-context.cc
@@ -437,8 +437,8 @@ void
TypeCheckContext::insert_resolved_predicate (HirId id,
TyTy::TypeBoundPredicate predicate)
{
- auto it = predicates.find (id);
- rust_assert (it == predicates.end ());
+ // auto it = predicates.find (id);
+ // rust_assert (it == predicates.end ());
predicates.insert ({id, predicate});
}
diff --git a/gcc/testsuite/rust/compile/issue-1524.rs b/gcc/testsuite/rust/compile/issue-1524.rs
new file mode 100644
index 00000000000..e46efe4595f
--- /dev/null
+++ b/gcc/testsuite/rust/compile/issue-1524.rs
@@ -0,0 +1,49 @@
+// { dg-additional-options "-w" }
+// https://github.com/Rust-GCC/gccrs/issues/1524
+// https://github.com/rust-lang/rust/blob/673d0db5e393e9c64897005b470bfeb6d5aec61b/src/test/ui/methods/method-normalize-bounds-issue-20604.rs
+trait Hasher {
+ type Output;
+ fn finish(&self) -> Self::Output;
+}
+
+trait Hash<H: Hasher> {
+ fn hash(&self, h: &mut H);
+}
+
+trait HashState {
+ type Wut: Hasher;
+ fn hasher(&self) -> Self::Wut;
+}
+
+struct SipHasher;
+impl Hasher for SipHasher {
+ type Output = u64;
+ fn finish(&self) -> u64 { 4 }
+}
+
+impl Hash<SipHasher> for isize {
+ fn hash(&self, h: &mut SipHasher) {}
+}
+
+struct SipState;
+impl HashState for SipState {
+ type Wut = SipHasher;
+ fn hasher(&self) -> SipHasher { SipHasher }
+}
+
+struct Map<S> {
+ s: S,
+}
+
+impl<S> Map<S>
+ where S: HashState,
+ <S as HashState>::Wut: Hasher<Output=u64>,
+{
+ fn foo<K>(&self, k: K) where K: Hash< <S as HashState>::Wut> {}
+}
+
+fn foo<K: Hash<SipHasher>>(map: &Map<SipState>) {
+ map.foo(22);
+}
+
+fn main() {}
More information about the Gcc-cvs
mailing list