[gcc r14-7312] gccrs: Replace gcc_unreachable with rust_sorry_at

Arthur Cohen cohenarthur@gcc.gnu.org
Tue Jan 16 17:21:41 GMT 2024


https://gcc.gnu.org/g:85629837c7d2df221a5b6c5035546658ed69c82c

commit r14-7312-g85629837c7d2df221a5b6c5035546658ed69c82c
Author: Owen Avery <powerboat9.gamer@gmail.com>
Date:   Mon Feb 27 10:23:19 2023 -0500

    gccrs: Replace gcc_unreachable with rust_sorry_at
    
    gcc/rust/ChangeLog:
    
            * typecheck/rust-hir-type-check-pattern.cc
            (TypeCheckPattern::visit): Improve error messages.
    
    Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>

Diff:
---
 gcc/rust/typecheck/rust-hir-type-check-pattern.cc | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/gcc/rust/typecheck/rust-hir-type-check-pattern.cc b/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
index 8f2a276b064..e57ac587ffe 100644
--- a/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
+++ b/gcc/rust/typecheck/rust-hir-type-check-pattern.cc
@@ -387,24 +387,24 @@ TypeCheckPattern::visit (HIR::IdentifierPattern &)
 }
 
 void
-TypeCheckPattern::visit (HIR::QualifiedPathInExpression &)
+TypeCheckPattern::visit (HIR::QualifiedPathInExpression &pattern)
 {
-  // TODO
-  gcc_unreachable ();
+  rust_sorry_at (pattern.get_locus (),
+		 "type checking qualified path patterns not supported");
 }
 
 void
-TypeCheckPattern::visit (HIR::ReferencePattern &)
+TypeCheckPattern::visit (HIR::ReferencePattern &pattern)
 {
-  // TODO
-  gcc_unreachable ();
+  rust_sorry_at (pattern.get_locus (),
+		 "type checking qualified path patterns not supported");
 }
 
 void
-TypeCheckPattern::visit (HIR::SlicePattern &)
+TypeCheckPattern::visit (HIR::SlicePattern &pattern)
 {
-  // TODO
-  gcc_unreachable ();
+  rust_sorry_at (pattern.get_locus (),
+		 "type checking qualified path patterns not supported");
 }
 
 } // namespace Resolver


More information about the Gcc-cvs mailing list