[gcc r13-8228] sparc: Revert membar optimization that is not suitable for LEON5

Daniel Hellstrom danielh@gcc.gnu.org
Tue Jan 16 12:04:58 GMT 2024


https://gcc.gnu.org/g:2e56fdcdfac1e6da35b0c95d5621b8699cc847c6

commit r13-8228-g2e56fdcdfac1e6da35b0c95d5621b8699cc847c6
Author: Andreas Larsson <andreas@gaisler.com>
Date:   Mon Jan 16 15:43:24 2023 +0100

    sparc: Revert membar optimization that is not suitable for LEON5
    
    LEON5 has a deeper write-buffer and hence stb is not enough to flush a
    write out. For compatibility, use the default V8 approach for both
    LEON3 and LEON5.
    
    This reverts commit 49cc765db35a5a21cab2aece27a44983fa70b94b,
    "sync.md (*membar_storeload_leon3): New insn."
    
    gcc/ChangeLog:
    
            * config/sparc/sync.md (*membar_storeload_leon3): Remove
            (*membar_storeload): Enable for LEON

Diff:
---
 gcc/config/sparc/sync.md | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/gcc/config/sparc/sync.md b/gcc/config/sparc/sync.md
index c34b943997f..dfa128f2488 100644
--- a/gcc/config/sparc/sync.md
+++ b/gcc/config/sparc/sync.md
@@ -64,19 +64,11 @@
   "stbar"
   [(set_attr "type" "multi")])
 
-;; For LEON3, STB has the effect of membar #StoreLoad.
-(define_insn "*membar_storeload_leon3"
-  [(set (match_operand:BLK 0 "" "")
-	(unspec:BLK [(match_dup 0) (const_int 2)] UNSPEC_MEMBAR))]
-  "TARGET_LEON3"
-  "stb\t%%g0, [%%sp-1]"
-  [(set_attr "type" "store")])
-
 ;; For V8, LDSTUB has the effect of membar #StoreLoad.
 (define_insn "*membar_storeload"
   [(set (match_operand:BLK 0 "" "")
 	(unspec:BLK [(match_dup 0) (const_int 2)] UNSPEC_MEMBAR))]
-  "TARGET_V8 && !TARGET_LEON3"
+  "TARGET_V8"
   "ldstub\t[%%sp-1], %%g0"
   [(set_attr "type" "multi")])


More information about the Gcc-cvs mailing list