[gcc(refs/vendors/riscv/heads/gcc-13-with-riscv-opts)] RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert
Jeff Law
law@gcc.gnu.org
Mon Sep 18 18:25:29 GMT 2023
https://gcc.gnu.org/g:178e88c27caa0109e6f68bba03774900889d0c36
commit 178e88c27caa0109e6f68bba03774900889d0c36
Author: Edwin Lu <ewlu@rivosinc.com>
Date: Tue Sep 12 09:31:40 2023 -0700
RISC-V: Finish Typing Un-Typed Instructions and Turn on Assert
Updates autovec instruction that was added after last patch and turns on the
assert statement to ensure all new instructions have a type.
* config/riscv/autovec-opt.md: Update type
* config/riscv/riscv.cc (riscv_sched_variable_issue): Enable assert
Reviewed-by: Jeff Law <jlaw@ventanamicro.com>
Signed-off-by: Edwin Lu <ewlu@rivosinc.com>
(cherry picked from commit 360c8cad6a727d5afd43017ca1ce9a84c6db61c5)
Diff:
---
gcc/config/riscv/autovec-opt.md | 3 ++-
gcc/config/riscv/riscv.cc | 2 --
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/gcc/config/riscv/autovec-opt.md b/gcc/config/riscv/autovec-opt.md
index 58e80044f1e..f1d058ce911 100644
--- a/gcc/config/riscv/autovec-opt.md
+++ b/gcc/config/riscv/autovec-opt.md
@@ -649,7 +649,8 @@
gen_int_mode (GET_MODE_NUNITS (<MODE>mode), Pmode)};
riscv_vector::expand_cond_len_unop (icode, ops);
DONE;
-})
+}
+[(set_attr "type" "vector")])
;; Combine vlmax neg and UNSPEC_VCOPYSIGN
(define_insn_and_split "*copysign<mode>_neg"
diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 0ecda795b38..9d04ddd69e0 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -7721,11 +7721,9 @@ riscv_sched_variable_issue (FILE *, int, rtx_insn *insn, int more)
if (get_attr_type (insn) == TYPE_GHOST)
return 0;
-#if 0
/* If we ever encounter an insn with an unknown type, trip
an assert so we can find and fix this problem. */
gcc_assert (get_attr_type (insn) != TYPE_UNKNOWN);
-#endif
return more - 1;
}
More information about the Gcc-cvs
mailing list