[gcc r13-6659] Revert latest change to emit_group_store

Eric Botcazou ebotcazou@gcc.gnu.org
Tue Mar 14 10:43:05 GMT 2023


https://gcc.gnu.org/g:8b6c38ef6a7a8cc1f7cc2ff86a686e07ceab1641

commit r13-6659-g8b6c38ef6a7a8cc1f7cc2ff86a686e07ceab1641
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Tue Mar 14 10:39:11 2023 +0100

    Revert latest change to emit_group_store
    
    This pessimizes on targets with insv instructions.
    
    gcc/
            PR rtl-optimization/107762
            * expr.cc (emit_group_store): Revert latest change.

Diff:
---
 gcc/expr.cc | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)

diff --git a/gcc/expr.cc b/gcc/expr.cc
index 78d35297e75..f8f5cc5a6ca 100644
--- a/gcc/expr.cc
+++ b/gcc/expr.cc
@@ -2902,16 +2902,14 @@ emit_group_store (rtx orig_dst, rtx src, tree type ATTRIBUTE_UNUSED,
 	dst = gen_reg_rtx (outer);
 
       /* Make life a bit easier for combine: if the first element of the
-	 vector is the word (or larger) low part of the destination mode,
-	 use a paradoxical subreg to initialize the destination.  */
+	 vector is the low part of the destination mode, use a paradoxical
+	 subreg to initialize the destination.  */
       if (start < finish)
 	{
 	  inner = GET_MODE (tmps[start]);
 	  bytepos = subreg_lowpart_offset (inner, outer);
-	  if (known_ge (GET_MODE_BITSIZE (inner), BITS_PER_WORD)
-	      && known_eq (rtx_to_poly_int64 (XEXP (XVECEXP (src, 0,
-							     start), 1)),
-			   bytepos))
+	  if (known_eq (rtx_to_poly_int64 (XEXP (XVECEXP (src, 0, start), 1)),
+			bytepos))
 	    {
 	      temp = simplify_gen_subreg (outer, tmps[start], inner, 0);
 	      if (temp)
@@ -2929,10 +2927,9 @@ emit_group_store (rtx orig_dst, rtx src, tree type ATTRIBUTE_UNUSED,
 	{
 	  inner = GET_MODE (tmps[finish - 1]);
 	  bytepos = subreg_lowpart_offset (inner, outer);
-	  if (known_ge (GET_MODE_BITSIZE (inner), BITS_PER_WORD)
-	      && known_eq (rtx_to_poly_int64 (XEXP (XVECEXP (src, 0,
-							     finish - 1), 1)),
-			   bytepos))
+	  if (known_eq (rtx_to_poly_int64 (XEXP (XVECEXP (src, 0,
+							  finish - 1), 1)),
+			bytepos))
 	    {
 	      temp = simplify_gen_subreg (outer, tmps[finish - 1], inner, 0);
 	      if (temp)


More information about the Gcc-cvs mailing list