[gcc r13-2347] i386: Fix conversion of move to/from AX_REG into xchg [PR106707]

Uros Bizjak uros@gcc.gnu.org
Thu Sep 1 18:20:56 GMT 2022


https://gcc.gnu.org/g:5205f5b54ad769969ffd89978ba1bcee41380bf8

commit r13-2347-g5205f5b54ad769969ffd89978ba1bcee41380bf8
Author: Uros Bizjak <ubizjak@gmail.com>
Date:   Thu Sep 1 20:20:06 2022 +0200

    i386: Fix conversion of move to/from AX_REG into xchg [PR106707]
    
    The conversion of a move pattern where both operands are AX_REG
    should be prevented.
    
    2022-09-01  Uroš Bizjak  <ubizjak@gmail.com>
    
    gcc/ChangeLog:
    
            PR target/106707
            * config/i386/i386.md (moves to/from AX_REG into xchg peephole2):
            Do not convert a move pattern where both operands are AX_REG.
    
    gcc/testsuite/ChangeLog:
    
            PR target/106707
            * gcc.target/i386/pr106707.c: New test.

Diff:
---
 gcc/config/i386/i386.md                  |  4 ++--
 gcc/testsuite/gcc.target/i386/pr106707.c | 19 +++++++++++++++++++
 2 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/gcc/config/i386/i386.md b/gcc/config/i386/i386.md
index a4a18cf89f5..1aef1af594d 100644
--- a/gcc/config/i386/i386.md
+++ b/gcc/config/i386/i386.md
@@ -3043,8 +3043,8 @@
   [(set (match_operand:SWI48 0 "general_reg_operand")
 	(match_operand:SWI48 1 "general_reg_operand"))]
  "optimize_size > 1
-  && (REGNO (operands[0]) == AX_REG
-      || REGNO (operands[1]) == AX_REG)
+  && ((REGNO (operands[0]) == AX_REG)
+      != (REGNO (operands[1]) == AX_REG))
   && optimize_insn_for_size_p ()
   && peep2_reg_dead_p (1, operands[1])"
   [(parallel [(set (match_dup 0) (match_dup 1))
diff --git a/gcc/testsuite/gcc.target/i386/pr106707.c b/gcc/testsuite/gcc.target/i386/pr106707.c
new file mode 100644
index 00000000000..a127ccd4679
--- /dev/null
+++ b/gcc/testsuite/gcc.target/i386/pr106707.c
@@ -0,0 +1,19 @@
+/* PR target/106707 */
+/* { dg-do compile { target int128 } } */
+/* { dg-options "-Oz -g -fno-cprop-registers -fno-dce" } */
+
+typedef unsigned __attribute__((__vector_size__ (8))) V;
+
+unsigned __int128 ii;
+unsigned x, y;
+
+V v;
+
+void
+foo (long a)
+{
+  long l = a != x;
+  int i = __builtin_add_overflow_p (y * ii, 0, 0);
+  V u = ii < x | v, w = x <= u < i & y <= x / ii;
+  v = __builtin_shufflevector (v, w, 1, 2) + (V) l;
+}


More information about the Gcc-cvs mailing list