[gcc r13-3717] ada: Remove useless validity suppression for attribute Input

Marc Poulhi?s dkm@gcc.gnu.org
Mon Nov 7 08:37:55 GMT 2022


https://gcc.gnu.org/g:f74a049a5371d421c5f4637dfae1ce0afc8a01ff

commit r13-3717-gf74a049a5371d421c5f4637dfae1ce0afc8a01ff
Author: Piotr Trojanek <trojanek@adacore.com>
Date:   Wed Oct 12 12:17:34 2022 +0200

    ada: Remove useless validity suppression for attribute Input
    
    Attributes 'Input and 'Read are similar, but only the 'Read denotes a
    subprogram with parameter of mode OUT where operand validity checks need
    to be suppressed.
    
    Cleanup related to fix for attributes 'Has_Same_Storage and
    'Overlaps_Storage.
    
    gcc/ada/
    
            * exp_attr.adb (Expand_N_Attribute_Reference): Remove useless
            skipping for attribute Input.

Diff:
---
 gcc/ada/exp_attr.adb | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/gcc/ada/exp_attr.adb b/gcc/ada/exp_attr.adb
index 1ef30656496..25f16276c5e 100644
--- a/gcc/ada/exp_attr.adb
+++ b/gcc/ada/exp_attr.adb
@@ -2002,8 +2002,8 @@ package body Exp_Attr is
       --
       --  Skip check for output parameters of an Asm instruction (since their
       --  valuesare not set till after the attribute has been elaborated),
-      --  for the arguments of a 'Read or 'Input attribute reference (since
-      --  the scalar argument is an OUT scalar) and for the arguments of a
+      --  for the arguments of a 'Read attribute reference (since the
+      --  scalar argument is an OUT scalar) and for the arguments of a
       --  'Has_Same_Storage or 'Overlaps_Storage attribute reference (which not
       --  considered to be reads of their prefixes and expressions, see Ada RM
       --  13.3(73.10/3)).
@@ -2011,7 +2011,6 @@ package body Exp_Attr is
       if Validity_Checks_On and then Validity_Check_Operands
         and then Id /= Attribute_Asm_Output
         and then Id /= Attribute_Read
-        and then Id /= Attribute_Input
         and then Id /= Attribute_Has_Same_Storage
         and then Id /= Attribute_Overlaps_Storage
       then


More information about the Gcc-cvs mailing list