[gcc r13-3701] Plug memory leak in attribute target_clones

Bernhard Reutner-Fischer aldot@gcc.gnu.org
Sun Nov 6 00:53:27 GMT 2022


https://gcc.gnu.org/g:07b0096e5b6749d88f5a22f694401abd6aaca551

commit r13-3701-g07b0096e5b6749d88f5a22f694401abd6aaca551
Author: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
Date:   Thu Nov 3 21:52:51 2022 +0100

    Plug memory leak in attribute target_clones
    
    It looks like there was some memory leak in the handling
    of attribute target_clones.
    
    Ok for trunk if testing passes?
    
    gcc/ChangeLog:
    
            * multiple_target.cc (expand_target_clones): Free memory.
    
    Signed-off-by: Bernhard Reutner-Fischer <aldot@gcc.gnu.org>

Diff:
---
 gcc/multiple_target.cc | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/gcc/multiple_target.cc b/gcc/multiple_target.cc
index 67866a7c963..77e0f21dd05 100644
--- a/gcc/multiple_target.cc
+++ b/gcc/multiple_target.cc
@@ -390,19 +390,23 @@ expand_target_clones (struct cgraph_node *node, bool definition)
   for (i = 0; i < attrnum; i++)
     {
       char *attr = attrs[i];
-      char *suffix = XNEWVEC (char, strlen (attr) + 1);
 
-      create_new_asm_name (attr, suffix);
       /* Create new target clone.  */
       tree attributes = make_attribute ("target", attr,
 					DECL_ATTRIBUTES (node->decl));
 
+      char *suffix = XNEWVEC (char, strlen (attr) + 1);
+      create_new_asm_name (attr, suffix);
       cgraph_node *new_node = create_target_clone (node, definition, suffix,
 						   attributes);
+      XDELETEVEC (suffix);
       if (new_node == NULL)
-	return false;
+	{
+	  XDELETEVEC (attrs);
+	  XDELETEVEC (attr_str);
+	  return false;
+	}
       new_node->local = false;
-      XDELETEVEC (suffix);
 
       decl2_v = new_node->function_version ();
       if (decl2_v != NULL)


More information about the Gcc-cvs mailing list