[gcc r12-8671] d: Fix ICE in in add_stack_var, at cfgexpand.cc:476

Iain Buclaw ibuclaw@gcc.gnu.org
Mon Aug 8 18:29:26 GMT 2022


https://gcc.gnu.org/g:fc7166a7c409bf231d5f243636f30904deea6e6f

commit r12-8671-gfc7166a7c409bf231d5f243636f30904deea6e6f
Author: Iain Buclaw <ibuclaw@gdcproject.org>
Date:   Mon Aug 8 15:17:47 2022 +0200

    d: Fix ICE in in add_stack_var, at cfgexpand.cc:476
    
    The type that triggers the ICE never got completed by the semantic
    analysis pass.  Checking for size forces it to be done, or issue a
    compile-time error.
    
            PR d/106555
    
    gcc/d/ChangeLog:
    
            * d-target.cc (Target::isReturnOnStack): Check for return type size.
    
    gcc/testsuite/ChangeLog:
    
            * gdc.dg/imports/pr106555.d: New test.
            * gdc.dg/pr106555.d: New test.
    
    (cherry picked from commit 4b0253b019943abf2cc5f4db0b7ed67caedffe4a)

Diff:
---
 gcc/d/d-target.cc                       |  2 ++
 gcc/testsuite/gdc.dg/imports/pr106555.d | 10 ++++++++++
 gcc/testsuite/gdc.dg/pr106555.d         |  4 ++++
 3 files changed, 16 insertions(+)

diff --git a/gcc/d/d-target.cc b/gcc/d/d-target.cc
index 610be74ad48..d4350e593e4 100644
--- a/gcc/d/d-target.cc
+++ b/gcc/d/d-target.cc
@@ -464,6 +464,8 @@ Target::isReturnOnStack (TypeFunction *tf, bool)
     return false;
 
   Type *tn = tf->next->toBasetype ();
+  if (tn->size () == SIZE_INVALID)
+    return false;
 
   return (tn->ty == TY::Tstruct || tn->ty == TY::Tsarray);
 }
diff --git a/gcc/testsuite/gdc.dg/imports/pr106555.d b/gcc/testsuite/gdc.dg/imports/pr106555.d
new file mode 100644
index 00000000000..0d3ab6bb747
--- /dev/null
+++ b/gcc/testsuite/gdc.dg/imports/pr106555.d
@@ -0,0 +1,10 @@
+module imports.pr106555;
+struct S106555
+{
+    int[] f106555;
+    int max106555;
+    this(int)
+    {
+        f106555.length = max106555;
+    }
+}
diff --git a/gcc/testsuite/gdc.dg/pr106555.d b/gcc/testsuite/gdc.dg/pr106555.d
new file mode 100644
index 00000000000..7b40f3c097b
--- /dev/null
+++ b/gcc/testsuite/gdc.dg/pr106555.d
@@ -0,0 +1,4 @@
+// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106555
+// { dg-do compile }
+// { dg-additional-options "-O2" }
+// { dg-additional-sources "imports/pr106555.d" }


More information about the Gcc-cvs mailing list