[gcc r12-3685] [Ada] Remove inappropriate test from Is_By_Reference_Type

[Pierre-Marie de Rodat]

https://gcc.gnu.org/g:d41be878c91e2e72cbd8bd68f793abc2c4b70563

commit r12-3685-gd41be878c91e2e72cbd8bd68f793abc2c4b70563
Author: Eric Botcazou <ebotcazou@adacore.com>
Date:   Mon Jun 21 16:13:25 2021 +0200

    [Ada] Remove inappropriate test from Is_By_Reference_Type
    
    gcc/ada/
    
            * sem_aux.adb (Is_By_Reference_Type): Do not test Error_Posted.

Diff:
---
 gcc/ada/sem_aux.adb | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gcc/ada/sem_aux.adb b/gcc/ada/sem_aux.adb
index ea3b59c0a1c..bce7c387ae3 100644
--- a/gcc/ada/sem_aux.adb
+++ b/gcc/ada/sem_aux.adb
@@ -846,10 +846,7 @@ package body Sem_Aux is
       Btype : constant Entity_Id := Base_Type (Ent);
 
    begin
-      if Error_Posted (Ent) or else Error_Posted (Btype) then
-         return False;
-
-      elsif Is_Private_Type (Btype) then
+      if Is_Private_Type (Btype) then
          declare
             Utyp : constant Entity_Id := Underlying_Type (Btype);
          begin