[gcc r12-3415] tree-optimization/102183 - sccvn: fix result compare in vn_nary_op_insert_into

Di Zhao dzhao@gcc.gnu.org
Wed Sep 8 10:52:34 GMT 2021


https://gcc.gnu.org/g:7285f394558980d1c7211f83c62b692af3c094eb

commit r12-3415-g7285f394558980d1c7211f83c62b692af3c094eb
Author: Di Zhao <dizhao@os.amperecomputing.com>
Date:   Wed Sep 8 15:34:27 2021 +0800

    tree-optimization/102183 - sccvn: fix result compare in vn_nary_op_insert_into
    
    If the first predicate value is different and copied, the comparison will then
    be between val->result and the copied one. That can cause inserting extra
    vn_pvals.
    
    gcc/ChangeLog:
    
            * tree-ssa-sccvn.c (vn_nary_op_insert_into): fix result compare

Diff:
---
 gcc/tree-ssa-sccvn.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c
index 2357bbdbf90..bfa516b6cf9 100644
--- a/gcc/tree-ssa-sccvn.c
+++ b/gcc/tree-ssa-sccvn.c
@@ -4105,7 +4105,7 @@ vn_nary_op_insert_into (vn_nary_op_t vno, vn_nary_op_table_type *table,
 	  bool found = false;
 	  for (vn_pval *val = (*slot)->u.values; val; val = val->next)
 	    {
-	      if (expressions_equal_p (val->result, vno->u.values->result))
+	      if (expressions_equal_p (val->result, nval->result))
 		{
 		  found = true;
 		  for (unsigned i = 0; i < val->n; ++i)


More information about the Gcc-cvs mailing list