[gcc(refs/users/marxin/heads/analyzer-dead-code-v2)] analyzer: remove dead code

Martin Liska marxin@gcc.gnu.org
Tue Mar 2 10:38:17 GMT 2021


https://gcc.gnu.org/g:5b7e3f6f5b857e3ecad42f5d4f74c8461cdc9e87

commit 5b7e3f6f5b857e3ecad42f5d4f74c8461cdc9e87
Author: Martin Liska <mliska@suse.cz>
Date:   Tue Mar 2 11:37:05 2021 +0100

    analyzer: remove dead code
    
    The issue is reported by Clang:
    
    warning: private field 'm_engine' is not used [-Wunused-private-field]
    
    gcc/analyzer/ChangeLog:
    
            * diagnostic-manager.cc (diagnostic_manager::emit_saved_diagnostics):
            Do not pass engine.

Diff:
---
 gcc/analyzer/diagnostic-manager.cc | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/gcc/analyzer/diagnostic-manager.cc b/gcc/analyzer/diagnostic-manager.cc
index f0f447f14dc..7f20841768b 100644
--- a/gcc/analyzer/diagnostic-manager.cc
+++ b/gcc/analyzer/diagnostic-manager.cc
@@ -545,8 +545,6 @@ public:
 class dedupe_winners
 {
 public:
-  dedupe_winners (engine *eng) : m_engine (eng) {}
-
   ~dedupe_winners ()
   {
     /* Delete all keys, but not the saved_diagnostics.  */
@@ -642,8 +640,6 @@ public:
   }
 
 private:
-  engine *m_engine;
-
   /* This maps from each dedupe_key to a current best saved_diagnostic.  */
 
   typedef hash_map<const dedupe_key *, saved_diagnostic *,
@@ -679,7 +675,7 @@ diagnostic_manager::emit_saved_diagnostics (const exploded_graph &eg)
      instance.  This partitions the saved diagnostics by dedupe_key,
      generating exploded_paths for them, and retaining the best one in each
      partition.  */
-  dedupe_winners best_candidates (eg.get_engine ());
+  dedupe_winners best_candidates;
 
   int i;
   saved_diagnostic *sd;


More information about the Gcc-cvs mailing list