[gcc r12-1247] openmp: Add testcase for scan directive with nested functions

Jakub Jelinek jakub@gcc.gnu.org
Sun Jun 6 17:40:26 GMT 2021


https://gcc.gnu.org/g:cb4b99be48af1c0911ce2a957af20d9cd946f364

commit r12-1247-gcb4b99be48af1c0911ce2a957af20d9cd946f364
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sun Jun 6 19:38:41 2021 +0200

    openmp: Add testcase for scan directive with nested functions
    
    > In convert_nonlocal_omp_clauses, the following clauses are
    > missing: OMP_CLAUSE_AFFINITY, OMP_CLAUSE_DEVICE_TYPE,
    > OMP_CLAUSE_EXCLUSIVE, OMP_CLAUSE_INCLUSIVE.
    
    OMP_CLAUSE_{EXCLUSIVE,INCLUSIVE} isn't needed, because we don't
    walk the clauses at all for GIMPLE_OMP_SCAN.  It would be a bug
    if we used the exclusive/inclusive operands after gimplification,
    but we apparently don't do that, all we check is whether the
    OMP_CLAUSE_KIND of the first clause (all should be the same) is
    OMP_CLAUSE_EXCLUSIVE or OMP_CLAUSE_INCLUSIVE, nothing else.
    
    That said, I think we should have a testcase.
    
    2021-06-06  Jakub Jelinek  <jakub@redhat.com>
    
            * gcc.dg/gomp/scan-1.c: New test.

Diff:
---
 gcc/testsuite/gcc.dg/gomp/scan-1.c | 51 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gcc/testsuite/gcc.dg/gomp/scan-1.c b/gcc/testsuite/gcc.dg/gomp/scan-1.c
new file mode 100644
index 00000000000..807071d9156
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/gomp/scan-1.c
@@ -0,0 +1,51 @@
+int baz (void);
+void qux (int);
+int r;
+
+int
+foo (void)
+{
+  int r = 0, i;
+  void bar (void) { r++; }
+  #pragma omp parallel for reduction(inscan, +:r)
+  for (i = 0; i < 64; i++)
+    {
+      r += baz ();
+      #pragma omp scan inclusive(r)
+      qux (r);
+    }
+  #pragma omp parallel for reduction(inscan, +:r)
+  for (i = 0; i < 64; i++)
+    {
+      qux (r);
+      #pragma omp scan exclusive(r)
+      r += baz ();
+    }
+  bar ();
+  return r;
+}
+
+int
+corge (void)
+{
+  int r = 0, i;
+  void bar (void)
+  {
+    #pragma omp parallel for reduction(inscan, +:r)
+    for (i = 0; i < 64; i++)
+      {
+	r += baz ();
+	#pragma omp scan inclusive(r)
+	qux (r);
+      }
+    #pragma omp parallel for reduction(inscan, +:r)
+    for (i = 0; i < 64; i++)
+      {
+	qux (r);
+	#pragma omp scan exclusive(r)
+	r += baz ();
+      }
+  }
+  bar ();
+  return r;
+}


More information about the Gcc-cvs mailing list