[gcc r12-5922] pch: Small cleanup

Jakub Jelinek jakub@gcc.gnu.org
Mon Dec 13 08:52:19 GMT 2021


https://gcc.gnu.org/g:7ed58b4274c58b11afdb52a3928c6cf2af92e8d0

commit r12-5922-g7ed58b4274c58b11afdb52a3928c6cf2af92e8d0
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Mon Dec 13 09:51:17 2021 +0100

    pch: Small cleanup
    
    > Fixed thusly, compile tested on x86_64-linux, committed to trunk.
    
    Here is a small cleanup.  IMHO we should use gt_pointer_operator instead of
    specifying manually void (*) (void *, void *) or
    void (*) (void *, void *, void *) so that next time we want to change it,
    we don't have to trace all the spots.  I was afraid it wouldn't work due to
    header dependencies, but it works well.  gengtype generated files also
    use gt_pointer_operator.
    
    2021-12-13  Jakub Jelinek  <jakub@redhat.com>
    
            * machmode.h (gt_pch_nx): Use gt_pointer_operator as type of second
            argument instead of equivalent void (*) (void *, void *, void *).
            * poly-int.h (gt_pch_nx): Likewise.
            * wide-int.h (gt_pch_nx): Likewise.
            * config/aarch64/aarch64-sve-builtins.cc (gt_pch_nx): Likewise.

Diff:
---
 gcc/config/aarch64/aarch64-sve-builtins.cc | 2 +-
 gcc/machmode.h                             | 2 +-
 gcc/poly-int.h                             | 2 +-
 gcc/wide-int.h                             | 4 ++--
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/gcc/config/aarch64/aarch64-sve-builtins.cc b/gcc/config/aarch64/aarch64-sve-builtins.cc
index 27be8b9253d..4250eaf785f 100644
--- a/gcc/config/aarch64/aarch64-sve-builtins.cc
+++ b/gcc/config/aarch64/aarch64-sve-builtins.cc
@@ -3913,7 +3913,7 @@ gt_pch_nx (function_instance *)
 }
 
 inline void
-gt_pch_nx (function_instance *, void (*) (void *, void *, void *), void *)
+gt_pch_nx (function_instance *, gt_pointer_operator, void *)
 {
 }
 
diff --git a/gcc/machmode.h b/gcc/machmode.h
index 2e5bafd0f96..5a43c66a70f 100644
--- a/gcc/machmode.h
+++ b/gcc/machmode.h
@@ -1199,7 +1199,7 @@ gt_pch_nx (pod_mode<T> *)
 
 template<typename T>
 void
-gt_pch_nx (pod_mode<T> *, void (*) (void *, void *, void *), void *)
+gt_pch_nx (pod_mode<T> *, gt_pointer_operator, void *)
 {
 }
 
diff --git a/gcc/poly-int.h b/gcc/poly-int.h
index 60a38c3ea61..f7226e68d42 100644
--- a/gcc/poly-int.h
+++ b/gcc/poly-int.h
@@ -2717,7 +2717,7 @@ gt_pch_nx (poly_int_pod<N, C> *)
 
 template<unsigned int N, typename C>
 void
-gt_pch_nx (poly_int_pod<N, C> *, void (*) (void *, void *, void *), void *)
+gt_pch_nx (poly_int_pod<N, C> *, gt_pointer_operator, void *)
 {
 }
 
diff --git a/gcc/wide-int.h b/gcc/wide-int.h
index d03a1741253..bc51aa9309f 100644
--- a/gcc/wide-int.h
+++ b/gcc/wide-int.h
@@ -3338,7 +3338,7 @@ gt_pch_nx (generic_wide_int <T> *)
 
 template<typename T>
 void
-gt_pch_nx (generic_wide_int <T> *, void (*) (void *, void *, void *), void *)
+gt_pch_nx (generic_wide_int <T> *, gt_pointer_operator, void *)
 {
 }
 
@@ -3356,7 +3356,7 @@ gt_pch_nx (trailing_wide_ints <N> *)
 
 template<int N>
 void
-gt_pch_nx (trailing_wide_ints <N> *, void (*) (void *, void *, void *), void *)
+gt_pch_nx (trailing_wide_ints <N> *, gt_pointer_operator, void *)
 {
 }


More information about the Gcc-cvs mailing list