[gcc r11-4950] cgraph: Avoid segfault when attempting to dump NULL clone_info

Martin Jambor jamborm@gcc.gnu.org
Thu Nov 12 19:03:05 GMT 2020


https://gcc.gnu.org/g:25a0d08b7f979ab3c6e970e1eb966c1b5ddbe9ac

commit r11-4950-g25a0d08b7f979ab3c6e970e1eb966c1b5ddbe9ac
Author: Martin Jambor <mjambor@suse.cz>
Date:   Thu Nov 12 19:56:07 2020 +0100

    cgraph: Avoid segfault when attempting to dump NULL clone_info
    
    cgraph_node::materialize_clone segfaulted when I tried compiling
    Tramp3D with -fdump-ipa-all because there was no clone_info - IPA-CP
    created a clone only for an aggregate constant, adding a note to its
    transformation summary but not creating any tree_map nor
    param_adjustements.
    
    Fixed with the following obvious extra checks which has passed
    bootstrap and testing on x86_64-linux.
    
    gcc/ChangeLog:
    
    2020-11-12  Martin Jambor  <mjambor@suse.cz>
    
            * cgraphclones.c (cgraph_node::materialize_clone): Check that clone
            info is not NULL before attempting to dump it.

Diff:
---
 gcc/cgraphclones.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/cgraphclones.c b/gcc/cgraphclones.c
index 2e69689025a..2bf9baf9cc8 100644
--- a/gcc/cgraphclones.c
+++ b/gcc/cgraphclones.c
@@ -1107,7 +1107,7 @@ cgraph_node::materialize_clone ()
       fprintf (symtab->dump_file, "cloning %s to %s\n",
 	       clone_of->dump_name (),
 	       dump_name ());
-      if (info->tree_map)
+      if (info && info->tree_map)
         {
 	  fprintf (symtab->dump_file, "    replace map:");
 	  for (unsigned int i = 0;
@@ -1123,7 +1123,7 @@ cgraph_node::materialize_clone ()
 	    }
 	  fprintf (symtab->dump_file, "\n");
 	}
-      if (info->param_adjustments)
+      if (info && info->param_adjustments)
 	info->param_adjustments->dump (symtab->dump_file);
     }
   clear_stmts_in_references ();


More information about the Gcc-cvs mailing list