[gcc(refs/vendors/redhat/heads/gcc-10-branch)] testsuite: Mention cleanup-13.c test is incompatible with -fcompare-debug [PR94296]

Jakub Jelinek jakub@gcc.gnu.org
Sat Mar 28 09:39:10 GMT 2020


https://gcc.gnu.org/g:780f1cfd8eef90f6f5ea84cf58aa97e07c0c2aa1

commit 780f1cfd8eef90f6f5ea84cf58aa97e07c0c2aa1
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Mar 25 11:41:17 2020 +0100

    testsuite: Mention cleanup-13.c test is incompatible with -fcompare-debug [PR94296]
    
    As this test produces different code depending on whether
    __GCC_HAVE_DWARF2_CFI_ASM macro is defined or not, it is inherently
    incompatible with -fcompare-debug, as with
    -fcompare-debug -fno-asynchronous-unwind-tables -fno-exceptions
    the macro is defined only in the -g case and not otherwise.
    The purpose of the macro is to tell when the compiler is emitting
    .cfi* directives itself and thus it is desirable that user code uses them in
    inline asm as well, so I think it is fine the way it is.
    As -fexceptions makes the test pass even in that case because it emits
    .cfi* directives, the test actually doesn't FAIL even with
    make check-gcc RUNTESTFLAGS='--target_board=unix/-fcompare-debug/-fno-asynchronous-unwind-tables/-fno-exceptions dg.exp=cleanup-13.c'
    so the intent of this patch is help Martin and others who do run gcc tests
    out of the testsuite with random compiler flags to find out that this is a
    known issue.
    
    2020-03-25  Jakub Jelinek  <jakub@redhat.com>
    
            PR debug/94296
            * gcc.dg/cleanup-13.c: Add a comment that the test is not
            -fcompare-debug compatible with certain other options.

Diff:
---
 gcc/testsuite/ChangeLog           | 4 ++++
 gcc/testsuite/gcc.dg/cleanup-13.c | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 5196036f64a..86d3b719ab8 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,9 @@
 2020-03-25  Jakub Jelinek  <jakub@redhat.com>
 
+	PR debug/94296
+	* gcc.dg/cleanup-13.c: Add a comment that the test is not
+	-fcompare-debug compatible with certain other options.
+
 	PR target/94308
 	* gcc.target/i386/pr94308.c: New test.
 
diff --git a/gcc/testsuite/gcc.dg/cleanup-13.c b/gcc/testsuite/gcc.dg/cleanup-13.c
index 1b7ea5c4b28..86cfae09e77 100644
--- a/gcc/testsuite/gcc.dg/cleanup-13.c
+++ b/gcc/testsuite/gcc.dg/cleanup-13.c
@@ -1,3 +1,7 @@
+/* This test is expected to FAIL to compile with
+   -fcompare-debug -fno-asynchronous-unwind-tables -fno-exceptions
+   because in that case, the __GCC_HAVE_DWARF2_CFI_ASM macro is only
+   defined during -g compilation and not defined with -g0.  */
 /* HP-UX libunwind.so doesn't provide _UA_END_OF_STACK */
 /* { dg-do run } */
 /* { dg-options "-fexceptions" } */


More information about the Gcc-cvs mailing list