[gcc/devel/omp/gcc-9] backport: re PR c++/90950 (OpenMP clause handling rejecting references to incomplete types in templa

Tobias Burnus burnus@gcc.gnu.org
Thu Mar 5 14:04:00 GMT 2020


https://gcc.gnu.org/g:fe8665498dc76eb6a5dd42f4e58e76436afb7bf6

commit fe8665498dc76eb6a5dd42f4e58e76436afb7bf6
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Jun 29 00:11:03 2019 +0200

    backport: re PR c++/90950 (OpenMP clause handling rejecting references to incomplete types in templates)
    
    	Backported from mainline
    	2019-06-21  Jakub Jelinek  <jakub@redhat.com>
    
    	PR c++/90950
    	* semantics.c (finish_omp_clauses): Don't reject references to
    	incomplete types if processing_template_decl.
    
    	* g++.dg/gomp/lastprivate-1.C: New test.
    
    From-SVN: r272801

Diff:
---
 gcc/cp/ChangeLog                          |  9 +++++++++
 gcc/cp/semantics.c                        |  3 ++-
 gcc/testsuite/ChangeLog                   |  5 +++++
 gcc/testsuite/g++.dg/gomp/lastprivate-1.C | 16 ++++++++++++++++
 4 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 881dcfb..fa0f937 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,12 @@
+2019-06-29  Jakub Jelinek  <jakub@redhat.com>
+
+	Backported from mainline
+	2019-06-21  Jakub Jelinek  <jakub@redhat.com>
+
+	PR c++/90950
+	* semantics.c (finish_omp_clauses): Don't reject references to
+	incomplete types if processing_template_decl.
+
 2019-06-12  Marek Polacek  <polacek@redhat.com>
 
 	PR c++/90825 - endless recursion when evaluating sizeof.
diff --git a/gcc/cp/semantics.c b/gcc/cp/semantics.c
index 3ae9cf0..6d40b14 100644
--- a/gcc/cp/semantics.c
+++ b/gcc/cp/semantics.c
@@ -7774,7 +7774,8 @@ finish_omp_clauses (tree clauses, enum c_omp_region_type ort)
 	  t = require_complete_type (t);
 	  if (t == error_mark_node)
 	    remove = true;
-	  else if (TYPE_REF_P (TREE_TYPE (t))
+	  else if (!processing_template_decl
+		   && TYPE_REF_P (TREE_TYPE (t))
 		   && !complete_type_or_else (TREE_TYPE (TREE_TYPE (t)), t))
 	    remove = true;
 	}
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index f4d47bc..1cf3149 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,6 +1,11 @@
 2019-06-29  Jakub Jelinek  <jakub@redhat.com>
 
 	Backported from mainline
+	2019-06-21  Jakub Jelinek  <jakub@redhat.com>
+
+	PR c++/90950
+	* g++.dg/gomp/lastprivate-1.C: New test.
+
 	2019-06-12  Jakub Jelinek  <jakub@redhat.com>
 
 	PR c/90760
diff --git a/gcc/testsuite/g++.dg/gomp/lastprivate-1.C b/gcc/testsuite/g++.dg/gomp/lastprivate-1.C
new file mode 100644
index 0000000..ce25e1a
--- /dev/null
+++ b/gcc/testsuite/g++.dg/gomp/lastprivate-1.C
@@ -0,0 +1,16 @@
+// PR c++/90950
+// { dg-do compile }
+
+template <typename T>
+T
+foo (void)
+{
+  T y = 0;
+  T &x = y;
+  #pragma omp parallel for lastprivate (x)
+  for (int i = 0; i < 8; ++i)
+    x = i;
+  return x;
+}
+
+int a = foo<int> ();



More information about the Gcc-cvs mailing list