[gcc/devel/ranger] i386: Fix *vec_extractv2sf_1 and *vec_extractv2sf_1 shufps alternative [PR93828]
Aldy Hernandez
aldyh@gcc.gnu.org
Wed Jun 17 19:04:13 GMT 2020
https://gcc.gnu.org/g:d56779b8ae587c599bf46b20587afcd6ee51fcaa
commit d56779b8ae587c599bf46b20587afcd6ee51fcaa
Author: Uros Bizjak <ubizjak@gmail.com>
Date: Thu Feb 20 21:06:18 2020 +0100
i386: Fix *vec_extractv2sf_1 and *vec_extractv2sf_1 shufps alternative [PR93828]
shufps moves two of the four packed single-precision floating-point values
from *destination* operand (first operand) into the low quadword of the
destination operand. Match source operand to the destination.
PR target/93828
* config/i386/mmx.md (*vec_extractv2sf_1): Match source operand
to destination operand for shufps alternative.
(*vec_extractv2si_1): Ditto.
testsuite/ChangeLog:
PR target/93828
* g++.target/i386/pr93828.C: New test.
Diff:
---
gcc/ChangeLog | 7 +++++++
gcc/config/i386/mmx.md | 8 ++++----
gcc/testsuite/ChangeLog | 5 +++++
3 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 95c883ebe49..15ce49c8c87 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,10 @@
+2020-02-20 Uroš Bizjak <ubizjak@gmail.com>
+
+ PR target/93828
+ * config/i386/mmx.md (*vec_extractv2sf_1): Match source operand
+ to destination operand for shufps alternative.
+ (*vec_extractv2si_1): Ditto.
+
2020-02-20 Peter Bergner <bergner@linux.ibm.com>
PR target/93658
diff --git a/gcc/config/i386/mmx.md b/gcc/config/i386/mmx.md
index f695831b5b9..e1c8b0af4c7 100644
--- a/gcc/config/i386/mmx.md
+++ b/gcc/config/i386/mmx.md
@@ -645,14 +645,14 @@
(define_insn "*vec_extractv2sf_1"
[(set (match_operand:SF 0 "nonimmediate_operand" "=y,x,x,y,x,f,r")
(vec_select:SF
- (match_operand:V2SF 1 "nonimmediate_operand" " 0,x,x,o,o,o,o")
+ (match_operand:V2SF 1 "nonimmediate_operand" " 0,x,0,o,o,o,o")
(parallel [(const_int 1)])))]
"(TARGET_MMX || TARGET_MMX_WITH_SSE)
&& !(MEM_P (operands[0]) && MEM_P (operands[1]))"
"@
punpckhdq\t%0, %0
%vmovshdup\t{%1, %0|%0, %1}
- shufps\t{$0xe5, %1, %0|%0, %1, 0xe5}
+ shufps\t{$0xe5, %0, %0|%0, %0, 0xe5}
#
#
#
@@ -1794,7 +1794,7 @@
(define_insn "*vec_extractv2si_1"
[(set (match_operand:SI 0 "nonimmediate_operand" "=y,rm,x,x,y,x,r")
(vec_select:SI
- (match_operand:V2SI 1 "nonimmediate_operand" " 0,x ,x,x,o,o,o")
+ (match_operand:V2SI 1 "nonimmediate_operand" " 0,x ,x,0,o,o,o")
(parallel [(const_int 1)])))]
"(TARGET_MMX || TARGET_MMX_WITH_SSE)
&& !(MEM_P (operands[0]) && MEM_P (operands[1]))"
@@ -1802,7 +1802,7 @@
punpckhdq\t%0, %0
%vpextrd\t{$1, %1, %0|%0, %1, 1}
%vpshufd\t{$0xe5, %1, %0|%0, %1, 0xe5}
- shufps\t{$0xe5, %1, %0|%0, %1, 0xe5}
+ shufps\t{$0xe5, %0, %0|%0, %0, 0xe5}
#
#
#"
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index e0399e01f2c..d6a153e54e3 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2020-02-20 Uroš Bizjak <ubizjak@gmail.com>
+
+ PR target/93828
+ * g++.target/i386/pr93828.C: New test.
+
2020-02-20 Peter Bergner <bergner@linux.ibm.com>
PR target/93658
More information about the Gcc-cvs
mailing list