[gcc r11-1346] RISC-V: Fix ICE on riscv_gpr_save_operation_p [PR95683]
Kito Cheng
kito@gcc.gnu.org
Tue Jun 16 02:15:27 GMT 2020
https://gcc.gnu.org/g:beaf12b49ae030505194cdcac18b5c8533a43921
commit r11-1346-gbeaf12b49ae030505194cdcac18b5c8533a43921
Author: Kito Cheng <kito.cheng@sifive.com>
Date: Tue Jun 16 10:14:13 2020 +0800
RISC-V: Fix ICE on riscv_gpr_save_operation_p [PR95683]
- riscv_gpr_save_operation_p might try to match parallel on other
patterns like inline asm pattern, and then it might trigger ther
assertion checking there, so we could trun it into a early exit check.
gcc/ChangeLog:
PR target/95683
* config/riscv/riscv.c (riscv_gpr_save_operation_p): Remove
assertion and turn it into a early exit check.
gcc/testsuite/ChangeLog
PR target/95683
* gcc.target/riscv/pr95683.c: New.
Diff:
---
gcc/config/riscv/riscv.c | 5 ++++-
gcc/testsuite/gcc.target/riscv/pr95683.c | 10 ++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/gcc/config/riscv/riscv.c b/gcc/config/riscv/riscv.c
index 328c0c823a3..bfb3885ed08 100644
--- a/gcc/config/riscv/riscv.c
+++ b/gcc/config/riscv/riscv.c
@@ -5216,7 +5216,10 @@ bool
riscv_gpr_save_operation_p (rtx op)
{
unsigned len = XVECLEN (op, 0);
- gcc_assert (len <= ARRAY_SIZE (gpr_save_reg_order));
+
+ if (len > ARRAY_SIZE (gpr_save_reg_order))
+ return false;
+
for (unsigned i = 0; i < len; i++)
{
rtx elt = XVECEXP (op, 0, i);
diff --git a/gcc/testsuite/gcc.target/riscv/pr95683.c b/gcc/testsuite/gcc.target/riscv/pr95683.c
new file mode 100644
index 00000000000..00cfbdcf282
--- /dev/null
+++ b/gcc/testsuite/gcc.target/riscv/pr95683.c
@@ -0,0 +1,10 @@
+/* PR target/95683 */
+/* { dg-options "-Os" } */
+/* { dg-do compile } */
+void a() {
+ asm(""
+ :
+ :
+ : "a0", "a1", "a2", "a3", "a4", "a5", "a6", "a7", "t0", "t1", "t2", "t3",
+ "t4", "t5", "t6", "ra");
+}
More information about the Gcc-cvs
mailing list