[gcc/devel/omp/gcc-10] Fix bug in processing of array dimensions in data clauses.

[Kwok Yeung]

https://gcc.gnu.org/g:cb581bdb6689d74c1849b7e6bc139c6f122fdcc2

commit cb581bdb6689d74c1849b7e6bc139c6f122fdcc2
Author: Sandra Loosemore <sandra@codesourcery.com>
Date:   Tue Mar 31 14:29:09 2020 -0700

    Fix bug in processing of array dimensions in data clauses.
    
    The g++ front end wraps the array length and low_bound values in
    NON_LVALUE_EXPR, causing the subsequent tests for INTEGER_CST to fail.
    The test case c-c++-common/goacc/kernels-loop-annotation-1.c was
    tickling this bug and giving bogus errors in g++ because it was falling
    through to dynamic array code instead of recognizing the constant bounds.
    
    This patch was posted upstream here
    https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542694.html
    but not yet committed.  It may be that some other fix for this problem
    is implemented on mainline instead; check before merging this patch.
    
    2020-03-31  Sandra Loosemore  <sandra@codesourcery.com>
    
            gcc/cp/
            * semantics.c (handle_omp_array_sections_1): Call STRIP_NOPS
            on length and low_bound;
            (handle_omp_array_sections): Likewise.

Diff:
---
 gcc/cp/ChangeLog.omp | 6 ++++++
 gcc/cp/semantics.c   | 9 +++++++++
 2 files changed, 15 insertions(+)

diff --git a/gcc/cp/ChangeLog.omp b/gcc/cp/ChangeLog.omp
index e77c2e1419c..d9bfa5e6276 100644
--- a/gcc/cp/ChangeLog.omp
+++ b/gcc/cp/ChangeLog.omp
@@ -1,3 +1,9 @@
+2020-03-31  Sandra Loosemore  <sandra@codesourcery.com>
+
+	* semantics.c (handle_omp_array_sections_1): Call STRIP_NOPS
+	on length and low_bound;
+	(handle_omp_array_sections): Likewise.
+
 2020-03-27  Sandra Loosemore  <sandra@codesourcery.com>
 
 	* decl.c (cp_unwrap_for_init): New.
diff --git a/gcc/cp/semantics.c b/gcc/cp/semantics.c
index c12e647a3b2..f268ff0e997 100644
--- a/gcc/cp/semantics.c
+++ b/gcc/cp/semantics.c
@@ -4864,6 +4864,10 @@ handle_omp_array_sections_1 (tree c, tree t, vec<tree> &types,
   if (length)
     length = mark_rvalue_use (length);
   /* We need to reduce to real constant-values for checks below.  */
+  if (length)
+    STRIP_NOPS (length);
+  if (low_bound)
+    STRIP_NOPS (low_bound);
   if (length)
     length = fold_simple (length);
   if (low_bound)
@@ -5173,6 +5177,11 @@ handle_omp_array_sections (tree c, enum c_omp_region_type ort)
 	  tree low_bound = TREE_PURPOSE (t);
 	  tree length = TREE_VALUE (t);
 
+	  if (length)
+	    STRIP_NOPS (length);
+	  if (low_bound)
+	    STRIP_NOPS (low_bound);
+
 	  i--;
 	  if (low_bound
 	      && TREE_CODE (low_bound) == INTEGER_CST