[gcc/devel/gccgo] libbacktrace: don't crash if ELF file has no sections
Ian Lance Taylor
ian@gcc.gnu.org
Sun Jul 12 18:04:48 GMT 2020
https://gcc.gnu.org/g:ef6394205d7bcab00dca01182d708ad5a6360a7b
commit ef6394205d7bcab00dca01182d708ad5a6360a7b
Author: Ian Lance Taylor <iant@golang.org>
Date: Sat May 9 20:34:25 2020 -0700
libbacktrace: don't crash if ELF file has no sections
libbacktrace/
* elf.c (elf_add): Bail early if there are no section headers at all.
Diff:
---
libbacktrace/ChangeLog | 4 ++++
libbacktrace/elf.c | 3 +++
2 files changed, 7 insertions(+)
diff --git a/libbacktrace/ChangeLog b/libbacktrace/ChangeLog
index 13d907011d8..88dee9983d3 100644
--- a/libbacktrace/ChangeLog
+++ b/libbacktrace/ChangeLog
@@ -1,3 +1,7 @@
+2020-05-09 Roland McGrath <mcgrathr@google.com>
+
+ * elf.c (elf_add): Bail early if there are no section headers at all.
+
2020-05-09 Ian Lance Taylor <iant@golang.org>
* elf.c (elf_add): Don't free strtab if an error occurs after
diff --git a/libbacktrace/elf.c b/libbacktrace/elf.c
index 1216af86fd9..80a00506bd6 100644
--- a/libbacktrace/elf.c
+++ b/libbacktrace/elf.c
@@ -2781,6 +2781,9 @@ elf_add (struct backtrace_state *state, const char *filename, int descriptor,
backtrace_release_view (state, &shdr_view, error_callback, data);
}
+ if (shnum == 0 || shstrndx == 0)
+ goto fail;
+
/* To translate PC to file/line when using DWARF, we need to find
the .debug_info and .debug_line sections. */
More information about the Gcc-cvs
mailing list