[gcc(refs/vendors/redhat/heads/gcc-9-branch)] Fix PR92950: Wrong code emitted for movv1qi
Jakub Jelinek
jakub@gcc.gnu.org
Wed Jan 22 20:21:00 GMT 2020
https://gcc.gnu.org/g:1228e6affbecc77d30e1d6ef172631c3fd3d1501
commit 1228e6affbecc77d30e1d6ef172631c3fd3d1501
Author: Andreas Krebbel <krebbel@linux.ibm.com>
Date: Tue Dec 17 08:37:26 2019 +0000
Fix PR92950: Wrong code emitted for movv1qi
The backend emits 16 bit memory loads for single element character
vector. As a result the character will not be right justified in the
GPR.
gcc/ChangeLog:
2019-12-17 Andreas Krebbel <krebbel@linux.ibm.com>
Backport from mainline
2019-12-16 Andreas Krebbel <krebbel@linux.ibm.com>
PR target/92950
* config/s390/vector.md ("mov<mode>" for V_8): Replace lh, lhy,
and lhrl with llc.
gcc/testsuite/ChangeLog:
2019-12-17 Andreas Krebbel <krebbel@linux.ibm.com>
Backport from mainline
2019-12-16 Andreas Krebbel <krebbel@linux.ibm.com>
PR target/92950
* gcc.target/s390/vector/pr92950.c: New test.
Diff:
---
gcc/ChangeLog | 9 +++++++++
gcc/config/s390/vector.md | 12 +++++-------
gcc/testsuite/ChangeLog | 8 ++++++++
gcc/testsuite/gcc.target/s390/vector/pr92950.c | 24 ++++++++++++++++++++++++
4 files changed, 46 insertions(+), 7 deletions(-)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 3845274..08ef204 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,12 @@
+2019-12-17 Andreas Krebbel <krebbel@linux.ibm.com>
+
+ Backport from mainline
+ 2019-12-16 Andreas Krebbel <krebbel@linux.ibm.com>
+
+ PR target/92950
+ * config/s390/vector.md ("mov<mode>" for V_8): Replace lh, lhy,
+ and lhrl with llc.
+
2019-12-12 Vineet Gupta <vgupta@synopsys.com>
Backport from mainline
diff --git a/gcc/config/s390/vector.md b/gcc/config/s390/vector.md
index 21cc765..6ca503b 100644
--- a/gcc/config/s390/vector.md
+++ b/gcc/config/s390/vector.md
@@ -295,9 +295,9 @@
; However, this would probably be slower.
(define_insn "mov<mode>"
- [(set (match_operand:V_8 0 "nonimmediate_operand" "=v,v,d,v,R, v, v, v, v,d, Q, S, Q, S, d, d,d,d,d,R,T")
- (match_operand:V_8 1 "general_operand" " v,d,v,R,v,j00,jm1,jyy,jxx,d,j00,j00,jm1,jm1,j00,jm1,R,T,b,d,d"))]
- ""
+ [(set (match_operand:V_8 0 "nonimmediate_operand" "=v,v,d,v,R, v, v, v, v,d, Q, S, Q, S, d, d,d,R,T")
+ (match_operand:V_8 1 "general_operand" " v,d,v,R,v,j00,jm1,jyy,jxx,d,j00,j00,jm1,jm1,j00,jm1,T,d,d"))]
+ "TARGET_VX"
"@
vlr\t%v0,%v1
vlvgb\t%v0,%1,0
@@ -315,12 +315,10 @@
mviy\t%0,-1
lhi\t%0,0
lhi\t%0,-1
- lh\t%0,%1
- lhy\t%0,%1
- lhrl\t%0,%1
+ llc\t%0,%1
stc\t%1,%0
stcy\t%1,%0"
- [(set_attr "op_type" "VRR,VRS,VRS,VRX,VRX,VRI,VRI,VRI,VRI,RR,SI,SIY,SI,SIY,RI,RI,RX,RXY,RIL,RX,RXY")])
+ [(set_attr "op_type" "VRR,VRS,VRS,VRX,VRX,VRI,VRI,VRI,VRI,RR,SI,SIY,SI,SIY,RI,RI,RXY,RX,RXY")])
(define_insn "mov<mode>"
[(set (match_operand:V_16 0 "nonimmediate_operand" "=v,v,d,v,R, v, v, v, v,d, Q, Q, d, d,d,d,d,R,T,b")
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index e6b91a9..d5789f97 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,11 @@
+2019-12-17 Andreas Krebbel <krebbel@linux.ibm.com>
+
+ Backport from mainline
+ 2019-12-16 Andreas Krebbel <krebbel@linux.ibm.com>
+
+ PR target/92950
+ * gcc.target/s390/vector/pr92950.c: New test.
+
2019-12-12 Harald Anlauf <anlauf@gmx.de>
Backport from mainline
diff --git a/gcc/testsuite/gcc.target/s390/vector/pr92950.c b/gcc/testsuite/gcc.target/s390/vector/pr92950.c
new file mode 100644
index 0000000..5084ce9
--- /dev/null
+++ b/gcc/testsuite/gcc.target/s390/vector/pr92950.c
@@ -0,0 +1,24 @@
+/* { dg-do run } */
+/* { dg-options "-O3 -mzarch -march=z13" } */
+
+struct a {
+ int b;
+ char c;
+};
+struct a d = {1, 16};
+struct a *e = &d;
+
+int f = 0;
+
+int main() {
+ struct a g = {0, 0 };
+ f = 0;
+
+ for (; f <= 1; f++) {
+ g = d;
+ *e = g;
+ }
+
+ if (d.c != 16)
+ __builtin_abort();
+}
More information about the Gcc-cvs
mailing list