[gcc(refs/users/marxin/heads/PR93274-make-resolver-static)] Make target_clones resolver fn static.

[Martin Liska]

https://gcc.gnu.org/g:8177a1a1b7ff132512f695e33b49216b7c976419

commit 8177a1a1b7ff132512f695e33b49216b7c976419
Author: Martin Liska <mliska@suse.cz>
Date:   Thu Jan 16 10:38:41 2020 +0100

    Make target_clones resolver fn static.
    
    gcc/ChangeLog:
    
    2020-01-17  Martin Liska  <mliska@suse.cz>
    
    	PR target/93274
    	* config/i386/i386-features.c (make_resolver_func):
    	Align the code with ppc64 target implementaion.
    	We do not need to have gnu_indirect_function
    	as a global function.
    
    gcc/testsuite/ChangeLog:
    
    2020-01-17  Martin Liska  <mliska@suse.cz>
    
    	PR target/93274
    	* gcc.target/i386/pr81213.c: Adjust to not expect
    	a global unique name.

Diff:
---
 gcc/config/i386/i386-features.c         | 20 +++++---------------
 gcc/testsuite/gcc.target/i386/pr81213.c |  4 ++--
 2 files changed, 7 insertions(+), 17 deletions(-)

diff --git a/gcc/config/i386/i386-features.c b/gcc/config/i386/i386-features.c
index e580b26..2517123 100644
--- a/gcc/config/i386/i386-features.c
+++ b/gcc/config/i386/i386-features.c
@@ -2738,26 +2738,17 @@ make_resolver_func (const tree default_decl,
 		    const tree ifunc_alias_decl,
 		    basic_block *empty_bb)
 {
-  char *resolver_name;
-  tree decl, type, decl_name, t;
+  tree decl, type, t;
 
-  /* IFUNC's have to be globally visible.  So, if the default_decl is
-     not, then the name of the IFUNC should be made unique.  */
-  if (TREE_PUBLIC (default_decl) == 0)
-    {
-      char *ifunc_name = make_unique_name (default_decl, "ifunc", true);
-      symtab->change_decl_assembler_name (ifunc_alias_decl,
-					  get_identifier (ifunc_name));
-      XDELETEVEC (ifunc_name);
-    }
-
-  resolver_name = make_unique_name (default_decl, "resolver", false);
+  /* Make the resolver function static.  The resolver function returns
+     void *.  */
+  tree decl_name = clone_function_name (default_decl, "resolver");
+  const char *resolver_name = IDENTIFIER_POINTER (decl_name);
 
   /* The resolver function should return a (void *). */
   type = build_function_type_list (ptr_type_node, NULL_TREE);
 
   decl = build_fn_decl (resolver_name, type);
-  decl_name = get_identifier (resolver_name);
   SET_DECL_ASSEMBLER_NAME (decl, decl_name);
 
   DECL_NAME (decl) = decl_name;
@@ -2809,7 +2800,6 @@ make_resolver_func (const tree default_decl,
 
   /* Create the alias for dispatch to resolver here.  */
   cgraph_node::create_same_body_alias (ifunc_alias_decl, decl);
-  XDELETEVEC (resolver_name);
   return decl;
 }
 
diff --git a/gcc/testsuite/gcc.target/i386/pr81213.c b/gcc/testsuite/gcc.target/i386/pr81213.c
index 13e15d5..89c4752 100644
--- a/gcc/testsuite/gcc.target/i386/pr81213.c
+++ b/gcc/testsuite/gcc.target/i386/pr81213.c
@@ -14,6 +14,6 @@ int main()
   return foo();
 }
 
-/* { dg-final { scan-assembler "\t.globl\tfoo\\..*\\.ifunc" } } */
+/* { dg-final { scan-assembler "\t.globl\tfoo" } } */
 /* { dg-final { scan-assembler "foo.resolver:" } } */
-/* { dg-final { scan-assembler "foo\\..*\\.ifunc, @gnu_indirect_function" } } */
+/* { dg-final { scan-assembler "foo\\, @gnu_indirect_function" } } */