[gcc/devel/c++-modules] re PR libgomp/93219 (unused return value in affinity-fmt.c)

Nathan Sidwell nathan@gcc.gnu.org
Wed Jan 15 14:29:00 GMT 2020


https://gcc.gnu.org/g:91df4397a1404df65de6de23426294c50ab88bd2

commit 91df4397a1404df65de6de23426294c50ab88bd2
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jan 10 21:42:00 2020 +0100

    re PR libgomp/93219 (unused return value in affinity-fmt.c)
    
    	PR libgomp/93219
    	* libgomp.h (gomp_print_string): Change return type from void to int.
    	* affinity-fmt.c (gomp_print_string): Likewise.  Return true if
    	not all characters have been written.
    
    From-SVN: r280137

Diff:
---
 libgomp/ChangeLog      | 7 +++++++
 libgomp/affinity-fmt.c | 4 ++--
 libgomp/libgomp.h      | 2 +-
 3 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/libgomp/ChangeLog b/libgomp/ChangeLog
index 78d6481..152e52c 100644
--- a/libgomp/ChangeLog
+++ b/libgomp/ChangeLog
@@ -1,3 +1,10 @@
+2020-01-10  Jakub Jelinek  <jakub@redhat.com>
+
+	PR libgomp/93219
+	* libgomp.h (gomp_print_string): Change return type from void to int.
+	* affinity-fmt.c (gomp_print_string): Likewise.  Return true if
+	not all characters have been written.
+
 2020-01-08  Tobias Burnus  <tobias@codesourcery.com>
 
 	* libgomp.texi: Fix typos, use https.
diff --git a/libgomp/affinity-fmt.c b/libgomp/affinity-fmt.c
index c423e35..9a5334d 100644
--- a/libgomp/affinity-fmt.c
+++ b/libgomp/affinity-fmt.c
@@ -37,10 +37,10 @@
 #include <sys/utsname.h>
 #endif
 
-void
+bool
 gomp_print_string (const char *str, size_t len)
 {
-  fwrite (str, 1, len, stderr);
+  return fwrite (str, 1, len, stderr) != len;
 }
 
 void
diff --git a/libgomp/libgomp.h b/libgomp/libgomp.h
index 01eb1fb..44703aa 100644
--- a/libgomp/libgomp.h
+++ b/libgomp/libgomp.h
@@ -832,7 +832,7 @@ extern void gomp_display_affinity_place (char *, size_t, size_t *, int);
 
 /* affinity-fmt.c */
 
-extern void gomp_print_string (const char *str, size_t len);
+extern bool gomp_print_string (const char *str, size_t len);
 extern void gomp_set_affinity_format (const char *, size_t);
 extern void gomp_display_string (char *, size_t, size_t *, const char *,
 				 size_t);



More information about the Gcc-cvs mailing list