[gcc/devel/c++-modules] Address 2 FIXMEs

Nathan Sidwell nathan@gcc.gnu.org
Fri Aug 7 15:46:05 GMT 2020


https://gcc.gnu.org/g:87f1ccd4c568f2b1648ad3824ae507ea36749fb8

commit 87f1ccd4c568f2b1648ad3824ae507ea36749fb8
Author: Nathan Sidwell <nathan@acm.org>
Date:   Fri Aug 7 08:42:44 2020 -0700

    Address 2 FIXMEs
    
            gcc/cp/
            * name-lookup.c (finish_nonmember_using_decl): Here.
            (lookup_type_scope_1): Here.

Diff:
---
 ChangeLog.modules    | 5 +++++
 gcc/cp/name-lookup.c | 6 ++----
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/ChangeLog.modules b/ChangeLog.modules
index bc02f4d5bec..069066f44be 100644
--- a/ChangeLog.modules
+++ b/ChangeLog.modules
@@ -1,5 +1,10 @@
 2020-08-07  Nathan Sidwell  <nathan@acm.org>
 
+	Address 2 FIXMEs.
+	gcc/cp/
+	* name-lookup.c (finish_nonmember_using_decl): Here.
+	(lookup_type_scope_1): Here.
+
 	Global decls.
 	gcc/cp/
 	* name-lookup.c (get_fixed_binding_slot): Skip internal decls when
diff --git a/gcc/cp/name-lookup.c b/gcc/cp/name-lookup.c
index 61b9a1522be..e9495d2a282 100644
--- a/gcc/cp/name-lookup.c
+++ b/gcc/cp/name-lookup.c
@@ -6392,8 +6392,7 @@ finish_nonmember_using_decl (tree scope, tree name)
 		   stat_hack, then everything was exported.  */
 		tree type = NULL_TREE;
 
-		// FIXME: Isn't STAT_HACK_P always true?  Or does its
-		// lack imply everything is visible?
+		/* If no stat hack, everything is visible.  */
 		if (STAT_HACK_P (value))
 		  {
 		    if (STAT_TYPE_VISIBLE_P (value))
@@ -8012,8 +8011,7 @@ lookup_type_scope_1 (tree name, tag_scope scope)
 		   stat_hack, then everything was exported.  */
 		tree type = NULL_TREE;
 
-		// FIXME: Isn't STAT_HACK_P always true?  Or does its
-		// lack imply everything is visible?
+		/* If no stat hack, everything is visible.  */
 		if (STAT_HACK_P (bind))
 		  {
 		    if (STAT_TYPE_VISIBLE_P (bind))


More information about the Gcc-cvs mailing list