r267833 - in /trunk/gcc: ChangeLog config/i386/...

jbeulich@gcc.gnu.org jbeulich@gcc.gnu.org
Fri Jan 11 11:20:00 GMT 2019


Author: jbeulich
Date: Fri Jan 11 11:20:40 2019
New Revision: 267833

URL: https://gcc.gnu.org/viewcvs?rev=267833&root=gcc&view=rev
Log:
x86-64: {,V}CVT{,U}SI2Sx are ambiguous without suffix

For 64-bit these should not be emitted without suffix in AT&T mode (as
being ambiguous that way); the suffixes are benign for 32-bit. For
consistency also omit the suffix in Intel mode for {,V}CVTSI2SxQ.

The omission has originally (prior to rev 260691) lead to wrong code
being generated for the 64-bit unsigned-to-float/double conversions (as
gas guesses an L suffix instead of the required Q one when the operand
is in memory). In all remaining cases (being changed here) the omission
would "just" lead to warnings with future gas versions.

As a result, arrange to check for the L suffixes in 32-bit test cases.

In order for related test cases to actually test what they're supposed
to test, add (seemingly unrelated) a few empty "asm volatile()".
Presumably there are more where constant propagation voids the intended
effect of the tests, but these are ones helping make sure the assembler
actually still assembles correctly the output after the changes here.

Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/config/i386/i386.md
    trunk/gcc/config/i386/sse.md
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtsd2si-1.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtsi2ss-1.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtss2si-1.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvttsd2si-1.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvttss2si-1.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtusi2sd-1.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtusi2sd-2.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtusi2sd64-2.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtusi2ss-1.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtusi2ss-2.c
    trunk/gcc/testsuite/gcc.target/i386/avx512f-vcvtusi2ss64-2.c
    trunk/gcc/testsuite/gcc.target/i386/pr19398.c



More information about the Gcc-cvs mailing list