r264305 - in /trunk/libgfortran: ChangeLog io/u...

[ktkachov@gcc.gnu.org]

Author: ktkachov
Date: Fri Sep 14 09:22:01 2018
New Revision: 264305

URL: https://gcc.gnu.org/viewcvs?rev=264305&root=gcc&view=rev
Log:
[libgfortran] Fix uninitialized variable use in fallback_access

I've been tracking down a bug in a Fortran program on a newlib target and it boils down to fallback_access doing something bad.
The unconditional calls to close cause havoc when open doesn't get called due to the short-circuiting in the if-statement above
because the fd is uninitialised. In my environment GCC ends up calling close on file descriptor 0, thus trying to close stdin.

This patch tightens up the calling so that close is called only when the corresponding open call succeeded.
With this my runtime failure disappears.

Bootstrapped and tested on aarch64-none-linux-gnu.
Though that doesn't exercise this call I hope it's an obviously correct change. 

	* io/unix.c (fallback_access): Avoid calling close on
	uninitialized file descriptor.


Modified:
    trunk/libgfortran/ChangeLog
    trunk/libgfortran/io/unix.c