gcc build_gcc

austern@gcc.gnu.org austern@gcc.gnu.org
Mon Jan 10 19:33:00 GMT 2005


CVSROOT:	/cvs/gcc
Module name:	gcc
Branch: 	apple-ppc-branch
Changes by:	austern@gcc.gnu.org	2005-01-10 19:33:28

Modified files:
	.              : build_gcc 

Log message:
	Radar 3894398, __eprintf & private_extern
	
	- Customer impact (why this needs to be fixed): As it stands, most nontrivial programs will have multiply defined symbols when compiled with 4.0.  (Because most nontrivial programs have more than one dylib, and most nontrivial projects use symbols from libgcc.)  This affects all languages.
	- Code reviewed by (name): Zem Laski
	- Code review date: 7 Jan 2005
	- Root build number the fix was tested in: n/a
	- Root build date: n/a
	- What did you do to test the fix:  I've run build_gcc on both a G4 and a G5 and verified that in both cases the ia32 and ppc32 versions do indeed have private extern symbols.  I've verified that the correct nmedit command gets run for the ppc64 version.
	- Is there a test case for this fix?  If not, why: Yes, it's attached to this bug report.  There is not a dg test case, because this bug only manifests itself only when there are multiple dylibs and dg prefers single-file test cases.
	- Other components affected by this fix (i.e., identify integration points): This bug affects link-time behavior, so the linker group may see some impact.
	- Other groups affected by the fix (i.e., QA, Pubs, other eng groups): QA will have to test it.  Otherwise, none.
	- Is there Localization impact? No.
	- Risk assessment: Medium.  This is a simple patch that's easy to understand; it's the addition of a few lines to a shell script.  On the other hand, symbol visibility in libgcc is an arcane enough area that we should keep a close eye on this.  I certainly recommend a side world build as part of the testing for this patch.

Patches:
http://gcc.gnu.org/cgi-bin/cvsweb.cgi/gcc/build_gcc.diff?cvsroot=gcc&only_with_tag=apple-ppc-branch&r1=1.1.2.29&r2=1.1.2.30



More information about the Gcc-cvs mailing list