[Bug middle-end/118627] gcc/omp-general.cc:4197: The code looks like reading uninitialised data

[burnus at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=118627

Tobias Burnus <burnus at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |openmp

--- Comment #3 from Tobias Burnus <burnus at gcc dot gnu.org> ---
Crossref: That code was added in commit
  r14-6515-g5fdb150cd4bf8f
    OpenMP/OpenACC: Rework clause expansion and nested struct handling

The called function
  static bool
  omp_parse_access_method (tree *expr0, enum access_method_kinds *kind)

duly sets 'kind' based on 'expr0', which might get modified. And then
unconditionally returns 'true'. -> Could be set 'void' (there is a single
caller, the one of comment 0). - And some more cleanup could be done.

For instance, omp_parse_access_methods also returns true unconditionally,
called in an if clause in 'omp_parse_expr'.

I checked some pending OpenMP patches but those do not modify/extend those
functions, either.