[Bug libgomp/106906] libgomp/env.c: 3 * boolean value assigned to pointer

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106906

--- Comment #2 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:e11babbfac21163118b69dd25b468ade80dbe8de

commit r13-2652-ge11babbfac21163118b69dd25b468ade80dbe8de
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Sep 13 19:00:02 2022 +0200

    libgomp: Appease some static analyzers [PR106906]

    While icv_addr[1] = false; assignments where icv_addr has void *
    element type is correct and matches how it is used (in those cases
    the void * pointer is then cast to bool and used that way), there is no
    reason not to add explicit (void *) casts there which are there already
    for (void *) true.  And, there is in fact even no point in actually
    doing those stores at all because we set that pointer to NULL a few
    lines earlier.  So, this patch adds the explicit casts and then
    comments those out to show intent.

    2022-09-13  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/106906
            * env.c (get_icv_member_addr): Cast false to void * before
assigning
            it to icv_addr[1], and comment the whole assignment out.